From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/3] kvm: use this_cpu_xxx replace percpu_xxx funcs Date: Mon, 21 Nov 2011 11:20:44 +0200 Message-ID: <4ECA17EC.5050803@redhat.com> References: <1318237851.27949.190.camel@debian> <1318324774.27949.693.camel@debian> <1318382964.27949.782.camel@debian> <1318428673.29699.13.camel@debian> <1318908091.23426.52.camel@debian> <1319016218.23426.104.camel@debian> <4E9E97D2.1040807@redhat.com> <1319096041.23426.182.camel@debian> <1319424608.5061.25.camel@debian> <4EA54694.5070703@redhat.com> <1321866128.30341.567.camel@debian> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Christoph Lameter , "tj@kernel.org" , "linux-kernel@vger.kernel.org" , "eric.dumazet@gmail.com" , "Huang, Ying" , "tglx@linutronix.de" , "mingo@redhat.com" , "akpm@linux-foundation.org" , "davem@davemloft.net" , "kaber@trash.net" , "a.p.zijlstra@chello.nl" , "kvm@vger.kernel.org" , "jeremy@xensource.com" To: "Alex,Shi" , Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:54626 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754090Ab1KUJVP (ORCPT ); Mon, 21 Nov 2011 04:21:15 -0500 In-Reply-To: <1321866128.30341.567.camel@debian> Sender: kvm-owner@vger.kernel.org List-ID: On 11/21/2011 11:02 AM, Alex,Shi wrote: > On Mon, 2011-10-24 at 19:05 +0800, Avi Kivity wrote: > > On 10/24/2011 04:50 AM, Alex,Shi wrote: > > > On Thu, 2011-10-20 at 15:34 +0800, Alex,Shi wrote: > > > > percpu_xxx funcs are duplicated with this_cpu_xxx funcs, so replace them > > > > for further code clean up. > > > > > > > > And in preempt safe scenario, __this_cpu_xxx funcs has a bit better > > > > performance since __this_cpu_xxx has no redundant preempt_disable() > > > > > > > > > > Avi: > > > Would you like to give some comments of this? > > > > > > > Sorry, was travelling: > > > > Acked-by: Avi Kivity > > > > And this one, picking up or comments are all appreciated. :) Just to be clear, you want this applied in kvm.git? -- error compiling committee.c: too many arguments to function