kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: zanghongyong@huawei.com
Cc: avi@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org,
	wusongwei@huawei.com, hanweidong@huawei.com,
	wuchangyi@huawei.com, louzhengwei@huawei.com,
	xiaowei.yang@huawei.com, james.chenjiabo@huawei.com,
	cam@cs.ualberta.ca
Subject: Re: [Qemu-devel] [PATCH] ivshmem: fix PCI BAR2 registration during initialization
Date: Mon, 21 Nov 2011 18:22:41 -0600	[thread overview]
Message-ID: <4ECAEB51.4060904@redhat.com> (raw)
In-Reply-To: <1321872978-3298-1-git-send-email-zanghongyong@huawei.com>

On 11/21/2011 04:56 AM, zanghongyong@huawei.com wrote:
> From: Hongyong Zang<zanghongyong@huawei.com>
>
> Ivshmem cannot work, and the command lspci cannot show ivshmem BAR2 in the guest.
> As for pci_register_bar(), parameter MemoryRegion should be s->bar instead of s->ivshmem.
>
> Signed-off-by: Hongyong Zang<zanghongyong@huawei.com>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   hw/ivshmem.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/ivshmem.c b/hw/ivshmem.c
> index 242fbea..2ecf658 100644
> --- a/hw/ivshmem.c
> +++ b/hw/ivshmem.c
> @@ -694,7 +694,7 @@ static int pci_ivshmem_init(PCIDevice *dev)
>           s->peers = g_malloc0(s->nb_peers * sizeof(Peer));
>
>           pci_register_bar(&s->dev, 2,
> -                         PCI_BASE_ADDRESS_SPACE_MEMORY,&s->ivshmem);
> +                         PCI_BASE_ADDRESS_SPACE_MEMORY,&s->bar);
>
>           s->eventfd_chr = g_malloc0(s->vectors * sizeof(CharDriverState *));
>


      parent reply	other threads:[~2011-11-22  0:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-21 10:56 [Qemu-devel] [PATCH] ivshmem: fix PCI BAR2 registration during initialization zanghongyong
2011-11-21 12:16 ` Avi Kivity
2011-11-22  0:22 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ECAEB51.4060904@redhat.com \
    --to=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=cam@cs.ualberta.ca \
    --cc=hanweidong@huawei.com \
    --cc=james.chenjiabo@huawei.com \
    --cc=kvm@vger.kernel.org \
    --cc=louzhengwei@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wuchangyi@huawei.com \
    --cc=wusongwei@huawei.com \
    --cc=xiaowei.yang@huawei.com \
    --cc=zanghongyong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).