From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org, takuya.yoshikawa@gmail.com
Subject: Re: [PATCH 1/7] KVM: x86 emulator: Use opcode::execute for IN/OUT
Date: Tue, 22 Nov 2011 12:57:17 +0200 [thread overview]
Message-ID: <4ECB800D.5070706@redhat.com> (raw)
In-Reply-To: <4ECB7E29.80202@redhat.com>
On 11/22/2011 12:49 PM, Avi Kivity wrote:
> On 11/22/2011 08:16 AM, Takuya Yoshikawa wrote:
> > IN : E4, E5, EC, ED
> > OUT: E6, E7, EE, EF
> >
> > @@ -3867,11 +3888,12 @@ special_insn:
> > case 0x6c: /* insb */
> > case 0x6d: /* insw/insd */
> > ctxt->src.val = ctxt->regs[VCPU_REGS_RDX];
> > - goto do_io_in;
> > + rc = em_in(ctxt);
> > + break;
> > case 0x6e: /* outsb */
> > case 0x6f: /* outsw/outsd */
> > ctxt->dst.val = ctxt->regs[VCPU_REGS_RDX];
> > - goto do_io_out;
> > + rc = em_out(ctxt);
> > break;
> > case 0x70 ... 0x7f: /* jcc (short) */
> > if (test_cc(ctxt->b, ctxt->eflags))
> >
>
> We have SrcDX/DstDX for these.
>
Everything else looks good; no need to regenerate this, it can be done
as a follow up patch if you like.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-11-22 10:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 6:15 [PATCH 0/7] KVM: x86 emulator: Use opcode::execute for some instructions Takuya Yoshikawa
2011-11-22 6:16 ` [PATCH 1/7] KVM: x86 emulator: Use opcode::execute for IN/OUT Takuya Yoshikawa
2011-11-22 10:49 ` Avi Kivity
2011-11-22 10:57 ` Avi Kivity [this message]
2011-11-23 3:27 ` [PATCH] KVM: x86 emulator: Use opcode::execute for INS/OUTS Takuya Yoshikawa
2011-11-27 16:35 ` Avi Kivity
2011-11-22 6:17 ` [PATCH 2/7] KVM: x86 emulator: Use opcode::execute for BT family Takuya Yoshikawa
2011-11-22 6:18 ` [PATCH 3/7] KVM: x86 emulator: Use opcode::execute for CALL Takuya Yoshikawa
2011-11-22 6:19 ` [PATCH 4/7] KVM: x86 emulator: Use opcode::execute for MOV to cr/dr Takuya Yoshikawa
2011-11-22 6:20 ` [PATCH 5/7] KVM: x86 emulator: Use opcode::execute for WRMSR/RDMSR Takuya Yoshikawa
2011-11-22 6:20 ` [PATCH 6/7] KVM: x86 emulator: Use opcode::execute for CMPXCHG Takuya Yoshikawa
2011-11-22 6:21 ` [PATCH 7/7] KVM: x86 emulator: Use opcode::execute for BSF/BSR Takuya Yoshikawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECB800D.5070706@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).