From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/7] KVM: x86 emulator: Use opcode::execute for IN/OUT Date: Tue, 22 Nov 2011 12:57:17 +0200 Message-ID: <4ECB800D.5070706@redhat.com> References: <20111122151546.80d9495d.yoshikawa.takuya@oss.ntt.co.jp> <20111122151654.ea0f7aa2.yoshikawa.takuya@oss.ntt.co.jp> <4ECB7E29.80202@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org, takuya.yoshikawa@gmail.com To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:7569 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756683Ab1KVK5W (ORCPT ); Tue, 22 Nov 2011 05:57:22 -0500 In-Reply-To: <4ECB7E29.80202@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/22/2011 12:49 PM, Avi Kivity wrote: > On 11/22/2011 08:16 AM, Takuya Yoshikawa wrote: > > IN : E4, E5, EC, ED > > OUT: E6, E7, EE, EF > > > > @@ -3867,11 +3888,12 @@ special_insn: > > case 0x6c: /* insb */ > > case 0x6d: /* insw/insd */ > > ctxt->src.val = ctxt->regs[VCPU_REGS_RDX]; > > - goto do_io_in; > > + rc = em_in(ctxt); > > + break; > > case 0x6e: /* outsb */ > > case 0x6f: /* outsw/outsd */ > > ctxt->dst.val = ctxt->regs[VCPU_REGS_RDX]; > > - goto do_io_out; > > + rc = em_out(ctxt); > > break; > > case 0x70 ... 0x7f: /* jcc (short) */ > > if (test_cc(ctxt->b, ctxt->eflags)) > > > > We have SrcDX/DstDX for these. > Everything else looks good; no need to regenerate this, it can be done as a follow up patch if you like. -- error compiling committee.c: too many arguments to function