From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: IOAPIC doesn't handle byte writes Date: Wed, 23 Nov 2011 12:45:33 +0200 Message-ID: <4ECCCECD.4010302@redhat.com> References: <1321974411.16507.25.camel@tabernacle.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: KVM devel mailing list To: Julian Stecklina Return-path: Received: from mx1.redhat.com ([209.132.183.28]:19979 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752716Ab1KWKpo (ORCPT ); Wed, 23 Nov 2011 05:45:44 -0500 In-Reply-To: <1321974411.16507.25.camel@tabernacle.lan> Sender: kvm-owner@vger.kernel.org List-ID: On 11/22/2011 05:06 PM, Julian Stecklina wrote: > Hello, [please don't drop cc list] > Avi Kivity wrote: > > Care to post a patch instead? > > Sure. Never hacked KVM, though. Is there a particular reason why the > void *val argument to ioapic_mmio_read/_write is only dereferenced when > ioapic->lock is not held? No particular reason. -- error compiling committee.c: too many arguments to function