From: Anthony Liguori <aliguori@us.ibm.com>
To: Eric B Munson <emunson@mgebm.net>
Cc: ryanh@linux.vnet.ibm.com, kvm@vger.kernel.org,
mtosatti@redhat.com, linux-kernel@vger.kernel.org,
qemu-devel@nongnu.org, avi@redhat.com
Subject: Re: [PATCH] Guest stop notification
Date: Tue, 29 Nov 2011 16:10:21 -0600 [thread overview]
Message-ID: <4ED5584D.9010606@us.ibm.com> (raw)
In-Reply-To: <1322602574-27072-1-git-send-email-emunson@mgebm.net>
On 11/29/2011 03:36 PM, Eric B Munson wrote:
> Often when a guest is stopped from the qemu console, it will report spurious
> soft lockup warnings on resume. There are kernel patches being discussed that
> will give the host the ability to tell the guest that it is being stopped and
> should ignore the soft lockup warning that generates.
>
> Signed-off-by: Eric B Munson<emunson@mgebm.net>
Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
Regards,
Anthony Liguori
> Cc: ryanh@linux.vnet.ibm.com
> Cc: aliguori@us.ibm.com
> Cc: mtosatti@redhat.com
> Cc: avi@redhat.com
> Cc: kvm@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> target-i386/kvm.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 5bfc21f..defd364 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -336,12 +336,18 @@ static int kvm_inject_mce_oldstyle(CPUState *env)
> return 0;
> }
>
> +static void kvm_put_guest_paused(CPUState *penv)
> +{
> + kvm_vcpu_ioctl(penv, KVM_GUEST_PAUSED, 0);
> +}
> +
> static void cpu_update_state(void *opaque, int running, RunState state)
> {
> CPUState *env = opaque;
>
> if (running) {
> env->tsc_valid = false;
> + kvm_put_guest_paused(env);
> }
> }
>
next prev parent reply other threads:[~2011-11-29 22:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 21:36 [PATCH] Guest stop notification Eric B Munson
2011-11-29 22:10 ` Anthony Liguori [this message]
2011-12-01 14:37 ` Jan Kiszka
2011-12-01 17:19 ` Eric B Munson
2011-12-01 17:31 ` Arend van Spriel
2011-12-01 17:35 ` Jan Kiszka
2011-12-01 17:35 ` Jan Kiszka
2011-12-01 21:22 ` Marcelo Tosatti
2011-12-01 17:22 ` Eric B Munson
2011-12-01 17:36 ` Jan Kiszka
2011-12-01 21:25 ` Marcelo Tosatti
2011-12-01 21:32 ` Eric B Munson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED5584D.9010606@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=emunson@mgebm.net \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ryanh@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).