From mboxrd@z Thu Jan  1 00:00:00 1970
From: Carsten Otte <cotte@de.ibm.com>
Subject: Re: [patch 04/12] [PATCH] kvm-s390-ucontrol: export SIE control block
 to user
Date: Thu, 01 Dec 2011 14:59:43 +0100
Message-ID: <4ED7884F.40000@de.ibm.com>
References: <20111201125732.085553111@de.ibm.com> <20111201130409.221824848@de.ibm.com> <4ED78091.1060801@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tossati <mtosatti@redhat.com>, borntrae@linux.vnet.ibm.com,
	heicars2@linux.vnet.ibm.com, mschwid2@linux.vnet.ibm.com,
	huckc@linux.vnet.ibm.com, KVM <kvm@vger.kernel.org>,
	Joachim von Buttlar <joachim_von_buttlar@de.ibm.com>,
	Jens Freimann <jfrei@de.ibm.com>,
	Constantin Werner <constantin.werner@de.ibm.com>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:50526 "EHLO
	e06smtp13.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754481Ab1LAOAS (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 1 Dec 2011 09:00:18 -0500
Received: from /spool/local
	by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted
	for <kvm@vger.kernel.org> from <cotte@de.ibm.com>;
	Thu, 1 Dec 2011 14:00:12 -0000
Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229])
	by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pB1E0A3K2330626
	for <kvm@vger.kernel.org>; Thu, 1 Dec 2011 14:00:10 GMT
Received: from d06av05.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av05.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pB1E08S6005097
	for <kvm@vger.kernel.org>; Thu, 1 Dec 2011 07:00:09 -0700
In-Reply-To: <4ED78091.1060801@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 01.12.2011 14:26, Avi Kivity wrote:
> On 12/01/2011 02:57 PM, Carsten Otte wrote:
>> This patch exports the SIE hardware control block to userspace
>> via the mapping of the vcpu file descriptor.
>>   	else if (vmf->pgoff == KVM_COALESCED_MMIO_PAGE_OFFSET)
>>   		page = virt_to_page(vcpu->kvm->coalesced_mmio_ring);
>>   #endif
>> +#if defined(CONFIG_S390)&&  defined(CONFIG_KVM_UCONTROL)
>> +	else if ((vmf->pgoff == KVM_SIE_PAGE_OFFSET)
>> +		&&  (!(vcpu->kvm->arch.gmap)))
>
> Is the second test "kvm_is_ucontrol()"?
Yes it is, but that is defined in arch/s390/kvm/kvm-s390.h which
I do not dare to include here.