From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 04/12] [PATCH] kvm-s390-ucontrol: export SIE control block to user Date: Thu, 01 Dec 2011 16:04:33 +0200 Message-ID: <4ED78971.1080508@redhat.com> References: <20111201125732.085553111@de.ibm.com> <20111201130409.221824848@de.ibm.com> <4ED78091.1060801@redhat.com> <4ED7884F.40000@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tossati , borntrae@linux.vnet.ibm.com, heicars2@linux.vnet.ibm.com, mschwid2@linux.vnet.ibm.com, huckc@linux.vnet.ibm.com, KVM , Joachim von Buttlar , Jens Freimann , Constantin Werner To: Carsten Otte Return-path: Received: from mx1.redhat.com ([209.132.183.28]:15195 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754215Ab1LAOEm (ORCPT ); Thu, 1 Dec 2011 09:04:42 -0500 In-Reply-To: <4ED7884F.40000@de.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/01/2011 03:59 PM, Carsten Otte wrote: > On 01.12.2011 14:26, Avi Kivity wrote: >> On 12/01/2011 02:57 PM, Carsten Otte wrote: >>> This patch exports the SIE hardware control block to userspace >>> via the mapping of the vcpu file descriptor. >>> else if (vmf->pgoff == KVM_COALESCED_MMIO_PAGE_OFFSET) >>> page = virt_to_page(vcpu->kvm->coalesced_mmio_ring); >>> #endif >>> +#if defined(CONFIG_S390)&& defined(CONFIG_KVM_UCONTROL) >>> + else if ((vmf->pgoff == KVM_SIE_PAGE_OFFSET) >>> + && (!(vcpu->kvm->arch.gmap))) >> >> Is the second test "kvm_is_ucontrol()"? > Yes it is, but that is defined in arch/s390/kvm/kvm-s390.h which > I do not dare to include here. > Oh, so kvm_arch_vcpu_fault() will help. The pio stuff sets a bad example, but we needn't follow it. -- error compiling committee.c: too many arguments to function