From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] Guest stop notification Date: Thu, 01 Dec 2011 18:35:24 +0100 Message-ID: <4ED7BADC.4070809@siemens.com> References: <1322602574-27072-1-git-send-email-emunson@mgebm.net> <4ED79138.60603@siemens.com> <20111201171938.GA8803@mgebm.net> <4ED7BA0C.5060702@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "ryanh@linux.vnet.ibm.com" , "aliguori@us.ibm.com" , "kvm@vger.kernel.org" , "mtosatti@redhat.com" , "qemu-devel@nongnu.org" , "linux-kernel@vger.kernel.org" , Eric B Munson , "avi@redhat.com" To: Arend van Spriel Return-path: In-Reply-To: <4ED7BA0C.5060702@broadcom.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 2011-12-01 18:31, Arend van Spriel wrote: > On 12/01/2011 06:19 PM, Eric B Munson wrote: >> On Thu, 01 Dec 2011, Jan Kiszka wrote: >> >>> On 2011-11-29 22:36, Eric B Munson wrote: >>>> + >>>> static void cpu_update_state(void *opaque, int running, RunState state) >>>> { >>>> CPUState *env = opaque; >>>> >>>> if (running) { >>>> env->tsc_valid = false; >>>> + kvm_put_guest_paused(env); >>> >>> checkpatch.pl would have asked you to remove this tab. >> >> Will change to spaces for V2. >> > > Huh. Remove what tab? Indent are always 8-space TAB according > CodingStyle doc: > > Chapter 1: Indentation > > Tabs are 8 characters, and thus indentations are also 8 characters. > There are heretic movements that try to make indentations 4 (or even 2!) > characters deep, and that is akin to trying to define the value of PI to > be 3. Don't worry, this is not kernel code. :) QEMU uses a different coding style. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux