From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Subject: Re: [Qemu-devel] [RFC][PATCH 02/16] kvm: Move kvmclock into hw/kvm
 folder
Date: Sat, 03 Dec 2011 20:00:05 +0100
Message-ID: <4EDA71B5.1060006@suse.de>
References: <cover.1322910904.git.jan.kiszka@web.de> <c67eb68ee0d0f461d5cf287a0a914f36d6d0ec99.1322910904.git.jan.kiszka@web.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>,
	Blue Swirl <blauwirbel@gmail.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel <qemu-devel@nongnu.org>, kvm@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cantor2.suse.de ([195.135.220.15]:54223 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753894Ab1LCTBD (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 3 Dec 2011 14:01:03 -0500
In-Reply-To: <c67eb68ee0d0f461d5cf287a0a914f36d6d0ec99.1322910904.git.jan.kiszka@web.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Am 03.12.2011 12:17, schrieb Jan Kiszka:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>=20
> More KVM-specific devices will come, so let's start with moving the
> kvmclock into a dedicated folder.
>=20
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---

> diff --git a/Makefile.target b/Makefile.target
> index 1e90df7..3a9e95d 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -231,7 +231,7 @@ obj-i386-y +=3D vmport.o
>  obj-i386-y +=3D device-hotplug.o pci-hotplug.o smbios.o wdt_ib700.o
>  obj-i386-y +=3D debugcon.o multiboot.o
>  obj-i386-y +=3D pc_piix.o
> -obj-i386-$(CONFIG_KVM) +=3D kvmclock.o
> +obj-i386-$(CONFIG_KVM) +=3D kvm/clock.o
>  obj-i386-$(CONFIG_SPICE) +=3D qxl.o qxl-logger.o qxl-render.o
> =20
>  # shared objects

> diff --git a/hw/kvmclock.c b/hw/kvm/clock.c
> similarity index 96%
> rename from hw/kvmclock.c
> rename to hw/kvm/clock.c
> index 5388bc4..aa37c5d 100644
> --- a/hw/kvmclock.c
> +++ b/hw/kvm/clock.c
> @@ -11,11 +11,11 @@
>   *
>   */
> =20
> -#include "qemu-common.h"
> -#include "sysemu.h"
> -#include "sysbus.h"
> -#include "kvm.h"
> -#include "kvmclock.h"
> +#include <qemu-common.h>
> +#include <sysemu.h>
> +#include <kvm.h>
> +#include <hw/sysbus.h>
> +#include <hw/kvm/clock.h>
> =20
>  #include <linux/kvm.h>
>  #include <linux/kvm_para.h>

Please don't start using system includes for everything. Rather extend
QEMU_CFLAGS to contain the right user include path(s).

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn=
berg