From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [RFC][PATCH 01/16] msi: Generalize msix_supported to msi_supported
Date: Sun, 04 Dec 2011 15:12:22 +0200
Message-ID: <4EDB71B6.5090508@redhat.com>
References: <cover.1322910904.git.jan.kiszka@web.de> <fcf06b2d32d56e7877652ceb6b5f2d4841bda112.1322910904.git.jan.kiszka@web.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org,
	qemu-devel <qemu-devel@nongnu.org>,
	Anthony Liguori <aliguori@us.ibm.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Blue Swirl <blauwirbel@gmail.com>
To: Jan Kiszka <jan.kiszka@web.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:47821 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752993Ab1LDNMa (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 4 Dec 2011 08:12:30 -0500
In-Reply-To: <fcf06b2d32d56e7877652ceb6b5f2d4841bda112.1322910904.git.jan.kiszka@web.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 12/03/2011 01:17 PM, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Rename msix_supported to msi_supported and control MSI and MSI-X
> activation this way. That was likely to original intention for this
> flag, but MSI support came after MSI-X.

'and' is a dangerous word in a changelog entry.

>
> +
> +    if (!msi_supported) {
> +        return -ENOTSUP;
> +    }
> +
>

This changes behaviour.  qemu 1.0 -M pc-1.0 and qemu-1.1 -M pc-1.0 will
be different after this, no?

-- 
error compiling committee.c: too many arguments to function