From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC][PATCH 10/16] memory: Introduce memory_region_init_reservation Date: Sun, 04 Dec 2011 15:20:26 +0200 Message-ID: <4EDB739A.8080201@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel , Anthony Liguori , "Michael S. Tsirkin" , Blue Swirl To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58754 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753468Ab1LDNUd (ORCPT ); Sun, 4 Dec 2011 08:20:33 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 12/03/2011 01:17 PM, Jan Kiszka wrote: > From: Jan Kiszka > > Introduce a memory region type that can reserve I/O space. Such regions > are useful for modeling I/O that is only handled outside of QEMU, i.e. > in the context of an accelerator like KVM. Any access to such a region > from QEMU is a bug and will be reported as such. This is guest triggerable (DMA into the region), so abort() is too drastic. > +void memory_region_init_reservation(MemoryRegion *mr, > + const char *name, > + uint64_t size) > +{ > + memory_region_init(mr, name, size); > + mr->ops = &reservation_ops; > + mr->opaque = mr; > + mr->terminates = true; > + mr->backend_registered = false; > +} Just calling memory_region_init_io() is simpler, no? -- error compiling committee.c: too many arguments to function