From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [RFC][PATCH 13/16] kvm: x86: Add user space part
 for in-kernel APIC
Date: Sun, 04 Dec 2011 15:24:56 +0200
Message-ID: <4EDB74A8.4040604@redhat.com>
References: <cover.1322910904.git.jan.kiszka@web.de>
	<912e2de9716af2e4e9b6c7605b3ea08e9000fd76.1322910904.git.jan.kiszka@web.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Anthony Liguori <aliguori@us.ibm.com>, kvm@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel <qemu-devel@nongnu.org>,
	Blue Swirl <blauwirbel@gmail.com>
To: Jan Kiszka <jan.kiszka@web.de>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <912e2de9716af2e4e9b6c7605b3ea08e9000fd76.1322910904.git.jan.kiszka@web.de>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
List-Id: kvm.vger.kernel.org

On 12/03/2011 01:17 PM, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> This introduces the alternative APIC model 'kvm-apic' which makes use of
> KVM's in-kernel device model. MSI is not yet supported, so we disable
> this when the in-kernel model is in use.
>
>  
> -    dev = qdev_create(NULL, "apic");
> +    if (kvm_enabled() && kvm_irqchip_in_kernel()) {
> +        dev = qdev_create(NULL, "kvm-apic");
> +    } else {
> +        dev = qdev_create(NULL, "apic");
> +    }

Is there anything that makes those two devices incompatible?


-- 
error compiling committee.c: too many arguments to function