From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: x86: Drop unused return value of kvm_mmu_remove_some_alloc_mmu_pages Date: Tue, 06 Dec 2011 12:41:19 +0200 Message-ID: <4EDDF14F.70804@redhat.com> References: <4ED90C5C.3080304@siemens.com> <4EDDE6CC.9060106@oss.ntt.co.jp> <4EDDF106.7080602@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , Marcelo Tosatti , kvm , Takuya Yoshikawa To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:31593 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933078Ab1LFKla (ORCPT ); Tue, 6 Dec 2011 05:41:30 -0500 In-Reply-To: <4EDDF106.7080602@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/06/2011 12:40 PM, Avi Kivity wrote: > > > > Is there any need for mmu_shrink()? > > Without it a user can easily pin large amounts of kernel memory by > filling guest memory with page tables and shadowing them all. It would make an interesting test case, btw, to try to crash the kernel this way, and exercise the shrinker. -- error compiling committee.c: too many arguments to function