From mboxrd@z Thu Jan 1 00:00:00 1970 From: Asias He Subject: Re: [PATCH 24/28] kvm tools: Fix virtio-pci endian bug when reading VIRTIO_PCI_QUEUE_NUM Date: Tue, 06 Dec 2011 19:28:44 +0800 Message-ID: <4EDDFC6C.1020404@gmail.com> References: <4EDD8F25.7080106@ozlabs.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Matt Evans , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, Sasha Levin , Ingo Molnar To: Pekka Enberg Return-path: Received: from mail-iy0-f174.google.com ([209.85.210.174]:39394 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753731Ab1LFLaF (ORCPT ); Tue, 6 Dec 2011 06:30:05 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 12/06/2011 06:26 PM, Pekka Enberg wrote: > On Tue, Dec 6, 2011 at 5:42 AM, Matt Evans wrote: >> The field size is currently wrong, read into a 32bit word instead of 16. This >> casues trouble when BE. >> >> Signed-off-by: Matt Evans >> --- >> tools/kvm/virtio/pci.c | 3 +-- >> 1 files changed, 1 insertions(+), 2 deletions(-) >> >> diff --git a/tools/kvm/virtio/pci.c b/tools/kvm/virtio/pci.c >> index 0ae93fb..6b27ff8 100644 >> --- a/tools/kvm/virtio/pci.c >> +++ b/tools/kvm/virtio/pci.c >> @@ -116,8 +116,7 @@ static bool virtio_pci__io_in(struct ioport *ioport, struct kvm *kvm, u16 port, >> break; >> case VIRTIO_PCI_QUEUE_NUM: >> val = vtrans->virtio_ops->get_size_vq(kvm, vpci->dev, vpci->queue_selector); >> - ioport__write32(data, val); >> - break; >> + ioport__write16(data, val); >> break; >> case VIRTIO_PCI_STATUS: >> ioport__write8(data, vpci->status); > > Looks good to me. Asias, Sasha? Looks good to me. -- Asias He