From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 02/10] nEPT: MMU context for nested EPT Date: Tue, 06 Dec 2011 15:07:36 +0200 Message-ID: <4EDE1398.7010004@redhat.com> References: <1320919040-nyh@il.ibm.com> <201111100958.pAA9wrIv019614@rice.haifa.ibm.com> <4EBBC848.7050400@redhat.com> <20111110144027.GB3327@fermat.math.technion.ac.il> <4EBBEB65.8050600@redhat.com> <20111110200532.GA17475@fermat.math.technion.ac.il> <4EBE4CE0.7070708@redhat.com> <20111112213747.GA741@fermat.math.technion.ac.il> <4EBFAA47.406@redhat.com> <4EBFD514.4030501@redhat.com> <20111206124004.GA31825@fermat.math.technion.ac.il> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Orit Wasserman , kvm@vger.kernel.org, "Roedel, Joerg" , abelg@il.ibm.com To: "Nadav Har'El" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:27723 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932941Ab1LFNHw (ORCPT ); Tue, 6 Dec 2011 08:07:52 -0500 In-Reply-To: <20111206124004.GA31825@fermat.math.technion.ac.il> Sender: kvm-owner@vger.kernel.org List-ID: On 12/06/2011 02:40 PM, Nadav Har'El wrote: > On Sun, Nov 13, 2011, Avi Kivity wrote about "Re: [PATCH 02/10] nEPT: MMU context for nested EPT": > > On 11/13/2011 01:30 PM, Orit Wasserman wrote: > > > Maybe this patch can help, this is roughly what Avi wants (I hope) done very quickly. > > > I'm sorry I don't have setup to run nested VMX at the moment so i can't test it. > >... > > > +#define PTTYPE EPT > > > +#include "paging_tmpl.h" > > > +#undef PTTYPE > > > > Yes, that's the key. > > I'm now preparing a patch based on such ideas. > > One downside of this approach is that mmu.c (and therefore the x86 > module) will now include EPT-specific functions that are of no use or > relevance to the SVM code. It's not a terrible disaster, but it's > "unclean". I'll try to think if there's a cleaner way. I'm perfectly willing to live with this. In general vmx.c and svm.c only deal with host-side differences between Intel and AMD. EPT support in paging.h is guest-side, so it doesn't belong there. -- error compiling committee.c: too many arguments to function