From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matt Evans <matt@ozlabs.org>
Subject: Re: [PATCH 23/28] kvm tools: Endian-sanitise pci.h and PCI device
 setup
Date: Wed, 07 Dec 2011 13:58:18 +1100
Message-ID: <4EDED64A.6060104@ozlabs.org>
References: <cover.1323141075.git.matt@ozlabs.org> <4EDD8F16.6060104@ozlabs.org> <CAOJsxLH1KYeLj4i=9rNOs_f3ZS9qhgJuBO7jbLjkCDQHLbyVNw@mail.gmail.com> <20111206102856.GB29781@moon> <CAOJsxLHehE9Dr-c-6tCsPYh5tr0Sm_CsycAUUg=6=Rjb2kPFEQ@mail.gmail.com> <20111206114755.GC29781@moon> <1323172704.1428.165.camel@jaguar> <20111206121005.GE29781@moon> <alpine.LFD.2.02.1112061528480.1646@tux.localdomain> <20111206133836.GH29781@moon>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Pekka Enberg <penberg@kernel.org>, kvm@vger.kernel.org,
	kvm-ppc@vger.kernel.org, Asias He <asias.hejun@gmail.com>,
	Sasha Levin <levinsasha928@gmail.com>,
	Ingo Molnar <mingo@elte.hu>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <20111206133836.GH29781@moon>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 07/12/11 00:38, Cyrill Gorcunov wrote:
> On Tue, Dec 06, 2011 at 03:29:00PM +0200, Pekka Enberg wrote:
>>>
>>> Hehe, this is because it should be rtaher defined as
>>>
>>> union pci_config_address {
>>> struct {
>>> #if __BYTE_ORDER == __LITTLE_ENDIAN
>>>   unsigned        zeros           : 2;
>>>   unsigned        register_number : 6;
>>> #else
>>>   ...
>>> #endif
>>> }
>>> u32 w;
>>> };
>>
>> Yup, that fixes it for me.
>>
> 
> Good. Matt, mind to update?

Absolutely -- thank you for digging in and debugging that!  I'll repost a V2.


Cheers,


Matt