From: Michael Tokarev <mjt@tls.msk.ru>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
KVM list <kvm@vger.kernel.org>,
"Justin M. Forbes" <jmforbes@linuxtx.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] winXP "Standard PC" HAL and qemu-kvm >= 0.15
Date: Wed, 07 Dec 2011 13:31:51 +0400 [thread overview]
Message-ID: <4EDF3287.8080605@msgid.tls.msk.ru> (raw)
In-Reply-To: <4EDF2BC0.10607@redhat.com>
On 07.12.2011 13:02, Kevin Wolf wrote:
> Am 06.12.2011 19:21, schrieb Jan Kiszka:
[]
>>> For the 0.15 .. 1.0 change, the first commit which restores the (broken
>>> in 0.15) functionality is this one:
>>>
>>> commit 86fbf97ceb4a9c46a609dd4ae053ba4262b68fe8
>>> Author: Jan Kiszka <jan.kiszka@siemens.com>
>>> Date: Fri Oct 7 09:19:45 2011 +0200
>>>
>>> i8259: Clear ELCR on reset
>>>
>>> The ELCR is actually part of the chipset but we model it here for
>>> simplicity reasons. The PIIX3 clears the ELCR on reset, which was once
>>> broken by 4dbe19e181. Fix this by splitting up pic_init_reset from
>>> pic_reset and clearing the register in the latter.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>>>
>>> Which is quite expected having in mind the commit which "broke"
>>> it for 0.15.
>>
>> Yep, makes a lot of sense. That patch should be applied to stable then
>> (who's in charge?).
>
> Justin, I guess (CCed). Not sure if we're planning to have another
> 0.15.x release, though.
Note that I haven't actually tested this commit alone on top of 0.15.
But I already commented on this - there's no good reason - imho anyway -
to fix that for 0.15. I'll try to push 1.0 to debian asap (waiting
for libvirt to catch up) to close this issue there, other distros
should hurry up too ;)
Thanks!
/mjt
prev parent reply other threads:[~2011-12-07 9:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 9:21 winXP "Standard PC" HAL and qemu-kvm >= 0.15 Michael Tokarev
2011-12-05 13:28 ` Avi Kivity
2011-12-05 20:19 ` Michael Tokarev
2011-12-06 10:32 ` Avi Kivity
2011-12-06 11:02 ` Michael Tokarev
2011-12-06 12:27 ` Michael S. Tsirkin
2011-12-06 14:45 ` Michael Tokarev
2011-12-06 16:29 ` [Qemu-devel] " Michael Tokarev
2011-12-06 16:38 ` Jan Kiszka
2011-12-06 16:57 ` Michael Tokarev
2011-12-06 17:45 ` Jan Kiszka
2011-12-06 18:13 ` Michael Tokarev
2011-12-06 18:21 ` Jan Kiszka
2011-12-06 18:45 ` Michael Tokarev
2011-12-06 19:38 ` Michael Tokarev
2011-12-06 20:58 ` Jan Kiszka
2011-12-06 21:12 ` Jan Kiszka
2011-12-07 7:11 ` [Qemu-devel] " Michael Tokarev
2011-12-07 9:02 ` Kevin Wolf
2011-12-07 9:31 ` Michael Tokarev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDF3287.8080605@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=jmforbes@linuxtx.org \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).