From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tokarev Subject: Re: [Qemu-devel] winXP "Standard PC" HAL and qemu-kvm >= 0.15 Date: Wed, 07 Dec 2011 13:31:51 +0400 Message-ID: <4EDF3287.8080605@msgid.tls.msk.ru> References: <4EDC8D06.20308@msgid.tls.msk.ru> <4EDCC6FE.8040702@redhat.com> <4EDD2763.8010808@msgid.tls.msk.ru> <4EDDEF26.9030403@redhat.com> <4EDDF659.6040701@msgid.tls.msk.ru> <20111206122752.GA31385@redhat.com> <4EDE2AA0.7090001@msgid.tls.msk.ru> <4EDE42EB.2020101@msgid.tls.msk.ru> <4EDE450B.6090801@siemens.com> <4EDE498A.2040309@msgid.tls.msk.ru> <4EDE5B3E.7000003@msgid.tls.msk.ru> <4EDE5D2A.2020809@siemens.com> <4EDF2BC0.10607@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , KVM list , "Justin M. Forbes" , "qemu-devel@nongnu.org" , Avi Kivity To: Kevin Wolf Return-path: Received: from isrv.corpit.ru ([86.62.121.231]:39942 "EHLO isrv.corpit.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752042Ab1LGJby (ORCPT ); Wed, 7 Dec 2011 04:31:54 -0500 In-Reply-To: <4EDF2BC0.10607@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07.12.2011 13:02, Kevin Wolf wrote: > Am 06.12.2011 19:21, schrieb Jan Kiszka: [] >>> For the 0.15 .. 1.0 change, the first commit which restores the (broken >>> in 0.15) functionality is this one: >>> >>> commit 86fbf97ceb4a9c46a609dd4ae053ba4262b68fe8 >>> Author: Jan Kiszka >>> Date: Fri Oct 7 09:19:45 2011 +0200 >>> >>> i8259: Clear ELCR on reset >>> >>> The ELCR is actually part of the chipset but we model it here for >>> simplicity reasons. The PIIX3 clears the ELCR on reset, which was once >>> broken by 4dbe19e181. Fix this by splitting up pic_init_reset from >>> pic_reset and clearing the register in the latter. >>> >>> Signed-off-by: Jan Kiszka >>> Signed-off-by: Blue Swirl >>> >>> Which is quite expected having in mind the commit which "broke" >>> it for 0.15. >> >> Yep, makes a lot of sense. That patch should be applied to stable then >> (who's in charge?). > > Justin, I guess (CCed). Not sure if we're planning to have another > 0.15.x release, though. Note that I haven't actually tested this commit alone on top of 0.15. But I already commented on this - there's no good reason - imho anyway - to fix that for 0.15. I'll try to push 1.0 to debian asap (waiting for libvirt to catch up) to close this issue there, other distros should hurry up too ;) Thanks! /mjt