From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: Document KVM_NMI Date: Wed, 07 Dec 2011 14:31:29 +0200 Message-ID: <4EDF5CA1.2030102@redhat.com> References: <1323254613-29882-1-git-send-email-avi@redhat.com> <1323255728.4009.7.camel@lappy> <4EDF5843.6020005@redhat.com> <1323260448.4009.8.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Sasha Levin Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42671 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755631Ab1LGMbc (ORCPT ); Wed, 7 Dec 2011 07:31:32 -0500 In-Reply-To: <1323260448.4009.8.camel@lappy> Sender: kvm-owner@vger.kernel.org List-ID: On 12/07/2011 02:20 PM, Sasha Levin wrote: > On Wed, 2011-12-07 at 14:12 +0200, Avi Kivity wrote: > > On 12/07/2011 01:02 PM, Sasha Levin wrote: > > > I don't see the QEMU patch doing a stop before grabbing LAPIC state. Or > > > does it happen somewhere before? > > > > It got dropped on the floor; it's now in next. > > I was talking about that patch you merged. I don't see where the vcpu is > being paused before getting the LAPIC state. > Oh, sorry. Well, once you exit from KVM_RUN, the vcpu is paused. It's really implied by the fact that vcpu ioctls must be issued from the same thread. -- error compiling committee.c: too many arguments to function