From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] KVM: VMX: Notify if VMX is already in use Date: Wed, 07 Dec 2011 16:23:18 +0200 Message-ID: <4EDF76D6.7020800@redhat.com> References: <1322764218-4698-1-git-send-email-levinsasha928@gmail.com> <4EDF7590.5060701@redhat.com> <1323267521.4009.11.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, Joerg Roedel , Marcelo Tosatti , kvm@vger.kernel.org To: Sasha Levin Return-path: In-Reply-To: <1323267521.4009.11.camel@lappy> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 12/07/2011 04:18 PM, Sasha Levin wrote: > On Wed, 2011-12-07 at 16:17 +0200, Avi Kivity wrote: > > On 12/01/2011 08:30 PM, Sasha Levin wrote: > > > Currently we silently fail if VMX is already in use by a different > > > virtualization technology. > > > > > > This is bad since it's non-obvious for the user, and its not too uncommon > > > for users to have several of these installed on same host. > > > > > > This patch adds a message to notify the user of the problem. > > > > > > > Does this actually happen? With which hypervisor? > > vbox > > It turns VMX/SVM on when it loads, regardless of whether it's running a > guest or not. That's odd. IIRC when we discussed this with them, they were executing VMXON/VMXOFF dynamically. Looks like they changed this. Anyway, please adjust according to Joerg's comment (and add the word "using"), and I'll apply. -- error compiling committee.c: too many arguments to function