From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org, takuya.yoshikawa@gmail.com
Subject: Re: [PATCH 0/4] KVM: x86 emulator: Move em_grp from switch statement to decode table
Date: Wed, 07 Dec 2011 18:51:03 +0200 [thread overview]
Message-ID: <4EDF9977.7070802@redhat.com> (raw)
In-Reply-To: <20111206180418.b4b40396.yoshikawa.takuya@oss.ntt.co.jp>
On 12/06/2011 11:04 AM, Takuya Yoshikawa wrote:
> I removed em_grp1a() and em_grp9() but kept em_grp2() and em_grp45()
> because they would produce a lot of trivial functions.
We could convert the various emulate_2op_blah() macros to generate
functions instead of statements, that would greatly reduce the boilerplate.
> Though I think it's almost done about the conversions, I do not have
> strong opinion about how to treat the remaining instructions: define
> em_default() and put those into it may be one way.
With em_insn() you have direct visibility as to what a decode table
entry describes. That doesn't work with em_default() or em_grpX().
> Anyway, now, rather readable than before.
>
Yes.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-12-07 16:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 9:04 [PATCH 0/4] KVM: x86 emulator: Move em_grp from switch statement to decode table Takuya Yoshikawa
2011-12-06 9:05 ` [PATCH 1/4] KVM: x86 emulator: Use opcode::execute for Group 2 instructions Takuya Yoshikawa
2011-12-07 16:38 ` Avi Kivity
2011-12-06 9:06 ` [PATCH 2/4] KVM: x86 emulator: Use opcode::execute for Group 1A instruction Takuya Yoshikawa
2011-12-06 9:06 ` [PATCH 3/4] KVM: x86 emulator: Use opcode::execute for Group 4/5 instructions Takuya Yoshikawa
2011-12-06 9:07 ` [PATCH 4/4] KVM: x86 emulator: Use opcode::execute for Group 9 instruction Takuya Yoshikawa
2011-12-07 16:51 ` Avi Kivity [this message]
2011-12-07 16:52 ` [PATCH 0/4] KVM: x86 emulator: Move em_grp from switch statement to decode table Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDF9977.7070802@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).