From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/4] KVM: x86 emulator: Move em_grp from switch statement to decode table Date: Wed, 07 Dec 2011 18:52:07 +0200 Message-ID: <4EDF99B7.9050600@redhat.com> References: <20111206180418.b4b40396.yoshikawa.takuya@oss.ntt.co.jp> <4EDF9977.7070802@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org, takuya.yoshikawa@gmail.com To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50240 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751922Ab1LGQwM (ORCPT ); Wed, 7 Dec 2011 11:52:12 -0500 In-Reply-To: <4EDF9977.7070802@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/07/2011 06:51 PM, Avi Kivity wrote: > On 12/06/2011 11:04 AM, Takuya Yoshikawa wrote: > > I removed em_grp1a() and em_grp9() but kept em_grp2() and em_grp45() > > because they would produce a lot of trivial functions. > > We could convert the various emulate_2op_blah() macros to generate > functions instead of statements, that would greatly reduce the boilerplate. > > > Though I think it's almost done about the conversions, I do not have > > strong opinion about how to treat the remaining instructions: define > > em_default() and put those into it may be one way. > > With em_insn() you have direct visibility as to what a decode table > entry describes. That doesn't work with em_default() or em_grpX(). > > > > Anyway, now, rather readable than before. > > > > Yes. > Forgot to mention, I applied 2-4, thanks. -- error compiling committee.c: too many arguments to function