From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Evans Subject: Re: [PATCH 05/28] kvm tools: 64-bit tidy; use PRIx64 when printf'ing u64s and link appropriately Date: Thu, 08 Dec 2011 17:17:22 +1100 Message-ID: <4EE05672.8000001@ozlabs.org> References: <20111206082827.GA30062@elte.hu> <20111206100538.GA8178@bloggs.ozlabs.ibm.com> <20111206102428.GB15966@elte.hu> <4EDF0F60.8080301@ozlabs.org> <20111207081602.GA8023@elte.hu> <4EE02BB2.5090908@ozlabs.org> <20111208044944.GB9485@elte.hu> <4EE0437F.5060505@ozlabs.org> <4EE04F6C.6090100@ozlabs.org> <20111208054943.GA13855@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Pekka Enberg , Paul Mackerras , Sasha Levin , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, Pekka Enberg To: Ingo Molnar Return-path: In-Reply-To: <20111208054943.GA13855@elte.hu> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 08/12/11 16:49, Ingo Molnar wrote: > > * Matt Evans wrote: > >> Since tools/kvm/include/linux/types.h only requires __u32, >> __u64 et al from , wouldn't it be most >> straightforward to just #include ? >> This avoids #define __KERNEL__ breaking other includes brought >> into userland, avoids changing system headers/distros, and >> includes the file we're really interested in on both x86 & >> PPC. > > No system headers need to be changed: you can just patch > powerpc/types.h with the extra __SANE_USERSPACE__ define (or any > suitable name) and the KVM tool should work as-is. > > The beauty of tools/kvm/ being integrated into the kernel tree. > > Really, if that works and if the PowerPC folks agree then we > have an immediate, fully adequate, instantly applicable > solution. Ahh, I finally understand you-- I'd earlier thought you were referring to the system headers' asm/types.h, etc. Thanks for your patience on this very trivial point :-) I'll add __SANE_USERSPACE_TYPES__ and we'll see how the others like it. >:) (Paul, that sound OK?) Thanks, Matt