From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 01/12] [PATCH] kvm-s390: ioctl to switch to user controlled virtual machines Date: Thu, 08 Dec 2011 11:45:05 +0200 Message-ID: <4EE08721.4060701@redhat.com> References: <20111208091230.874920251@de.ibm.com> <20111208091728.908715499@de.ibm.com> <1323336309.3904.12.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Carsten Otte , Marcelo Tossati , Christian Borntraeger , Heiko Carstens , Martin Schwidefsky , Cornelia Huck , KVM , Joachim von Buttlar , Jens Freimann , Constantin Werner , Alexander Graf , Xiantao Zhang To: Sasha Levin Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41873 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752971Ab1LHJpQ (ORCPT ); Thu, 8 Dec 2011 04:45:16 -0500 In-Reply-To: <1323336309.3904.12.camel@lappy> Sender: kvm-owner@vger.kernel.org List-ID: On 12/08/2011 11:25 AM, Sasha Levin wrote: > On Thu, 2011-12-08 at 10:12 +0100, Carsten Otte wrote: > > plain text document attachment (enable-ucontrol.patch) > > This patch introduces a new config option for user controlled kernel > > virtual machines. It introduces an optional parameter to > > KVM_CREATE_VM in order to create a user controlled virtual machine. > > The parameter is passed to kvm_arch_init_vm for all architectures. > > Valid values for the new parameter are KVM_VM_REGULAR (defined to 0 > > for backward compatibility to old KVM_CREATE_VM) and > > KVM_VM_S390_UCONTROL for s390 only. > > Why is it s390 specific? why isn't it KVM_VM_UCONTROL which is currently > only implemented on s390? It's not possible (or at least very difficult) to implement ucontrol on x86. For example, to update VMCSs you need privileged instructions. It might be doable on svm, but there's no point, really. -- error compiling committee.c: too many arguments to function