From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: [patch 01/12] [PATCH] kvm-s390: ioctl to switch to user controlled virtual machines Date: Thu, 08 Dec 2011 12:48:04 +0100 Message-ID: <4EE0A3F4.6000104@de.ibm.com> References: <20111208091230.874920251@de.ibm.com> <20111208091728.908715499@de.ibm.com> <1323336309.3904.12.camel@lappy> <4EE08721.4060701@redhat.com> <1323338029.3904.15.camel@lappy> <4EE08A8B.8080502@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Sasha Levin , Marcelo Tossati , borntrae@linux.vnet.ibm.com, heicars2@linux.vnet.ibm.com, mschwid2@linux.vnet.ibm.com, huckc@linux.vnet.ibm.com, KVM , Joachim von Buttlar , Jens Freimann , Constantin Werner , Xiantao Zhang To: Alexander Graf Return-path: Received: from e06smtp18.uk.ibm.com ([195.75.94.114]:57300 "EHLO e06smtp18.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751142Ab1LHLsf (ORCPT ); Thu, 8 Dec 2011 06:48:35 -0500 Received: from /spool/local by e06smtp18.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 8 Dec 2011 11:48:33 -0000 Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pB8BmV282908374 for ; Thu, 8 Dec 2011 11:48:31 GMT Received: from d06av11.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pB8BmThF013847 for ; Thu, 8 Dec 2011 04:48:31 -0700 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 08.12.2011 11:18, Alexander Graf wrote: > If you really have to do this, please > > 1) make it s390 only. I don't even want to have to see this uglyness in other archs It pretty much is. The only interference is a) checking the machine type in arch_init_vm now that I've introduced that parameter to CREATE_VM on Avi's request and b) a dummy arch_vcpu_fault function that I've introduced on Avi's request. Both changes make sense for future enhancements independent of ucontrol. so long, Carsten