From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [patch 01/12] [PATCH] kvm-s390: ioctl to switch to user controlled virtual machines Date: Thu, 08 Dec 2011 14:16:08 +0100 Message-ID: <4EE0B898.2090903@suse.de> References: <20111208091230.874920251@de.ibm.com> <20111208091728.908715499@de.ibm.com> <1323336309.3904.12.camel@lappy> <4EE08721.4060701@redhat.com> <1323338029.3904.15.camel@lappy> <4EE08A8B.8080502@redhat.com> <4EE0A3F4.6000104@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Sasha Levin , Marcelo Tossati , borntrae@linux.vnet.ibm.com, heicars2@linux.vnet.ibm.com, mschwid2@linux.vnet.ibm.com, huckc@linux.vnet.ibm.com, KVM , Joachim von Buttlar , Jens Freimann , Constantin Werner , Xiantao Zhang To: Carsten Otte Return-path: Received: from cantor2.suse.de ([195.135.220.15]:51865 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751454Ab1LHNK1 (ORCPT ); Thu, 8 Dec 2011 08:10:27 -0500 In-Reply-To: <4EE0A3F4.6000104@de.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/08/2011 12:48 PM, Carsten Otte wrote: > On 08.12.2011 11:18, Alexander Graf wrote: >> If you really have to do this, please >> >> 1) make it s390 only. I don't even want to have to see this >> uglyness in other archs > It pretty much is. The only interference is a) checking the machine > type in arch_init_vm now that I've introduced that parameter to > CREATE_VM on Avi's request and b) a dummy arch_vcpu_fault function that > I've introduced on Avi's request. Both changes make sense for future > enhancements independent of ucontrol. Ah, so you're only introducing a generic framework for mmapping pages between user space and kernel space. That's arch-independent of course and a good idea :) Alex