Re: [libvirt] [PATCH] kvm tools: Introduce an ENV variable for the state dir

[Osier Yang <jyang@redhat.com>]

On 2011年12月06日 22:39, Daniel P. Berrange wrote:
> On Fri, Nov 11, 2011 at 07:57:00PM +0800, Osier Yang wrote:
>> Which is named as "KVMTOOL_STATE_DIR", so that the user can
>> configure the path of state directly as he wants.
>> ---
>>   tools/kvm/main.c |    7 ++++++-
>>   1 files changed, 6 insertions(+), 1 deletions(-)
>>
>> diff --git a/tools/kvm/main.c b/tools/kvm/main.c
>> index 05bc82c..37b2b1d 100644
>> --- a/tools/kvm/main.c
>> +++ b/tools/kvm/main.c
>> @@ -13,7 +13,12 @@ static int handle_kvm_command(int argc, char **argv)
>>
>>   int main(int argc, char *argv[])
>>   {
>> -	kvm__set_dir("%s/%s", HOME_DIR, KVM_PID_FILE_PATH);
>> +	char *state_dir = getenv("KVMTOOL_STATE_DIR");
>> +
>> +	if (state_dir)
>> +		kvm__set_dir("%s", state_dir);
>> +	else
>> +		kvm__set_dir("%s/%s", HOME_DIR, KVM_PID_FILE_PATH);
>>
>>   	return handle_kvm_command(argc - 1,&argv[1]);
>>   }
>
> As per my comments in the first patch, I don't think this is critical
> for libvirt's needs. We should just honour the default location that
> the KVM tool uses, rather than forcing a libvirt specific location.
>

Thanks for the guy who pushed the patch, it's already in kvmtool's
source. It will be useful when we run the kvmtool process as 
non-priviledge user and group.

Regards,
Osier