From mboxrd@z Thu Jan 1 00:00:00 1970 From: Osier Yang Subject: Re: [libvirt] [PATCH 5/7] kvmtool: Add new domain type Date: Fri, 09 Dec 2011 15:22:32 +0800 Message-ID: <4EE1B738.6090209@redhat.com> References: <1321012626-31713-1-git-send-email-jyang@redhat.com> <1321012626-31713-7-git-send-email-jyang@redhat.com> <20111206144640.GC7937@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: libvir-list@redhat.com, kvm@vger.kernel.org, penberg@cs.helsinki.fi, levinsasha928@gmail.com, gorcunov@gmail.com, mingo@elte.hu, asias.hejun@gmail.com To: "Daniel P. Berrange" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:1943 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770Ab1LIHWj (ORCPT ); Fri, 9 Dec 2011 02:22:39 -0500 In-Reply-To: <20111206144640.GC7937@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2011=E5=B9=B412=E6=9C=8806=E6=97=A5 22:46, Daniel P. Berrange wrote: > On Fri, Nov 11, 2011 at 07:57:04PM +0800, Osier Yang wrote: >> It's named as "kvmtool". >> --- >> src/conf/domain_conf.c | 4 +++- >> src/conf/domain_conf.h | 1 + >> 2 files changed, 4 insertions(+), 1 deletions(-) >> >> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c >> index 58f4d0f..55121d8 100644 >> --- a/src/conf/domain_conf.c >> +++ b/src/conf/domain_conf.c >> @@ -91,7 +91,8 @@ VIR_ENUM_IMPL(virDomainVirt, VIR_DOMAIN_VIRT_LAST, >> "hyperv", >> "vbox", >> "one", >> - "phyp") >> + "phyp", >> + "kvmtool") >> >> VIR_ENUM_IMPL(virDomainBoot, VIR_DOMAIN_BOOT_LAST, >> "fd", >> @@ -4018,6 +4019,7 @@ virDomainChrDefParseXML(virCapsPtr caps, >> if (type =3D=3D NULL) { >> def->source.type =3D VIR_DOMAIN_CHR_TYPE_PTY; >> } else if ((def->source.type =3D virDomainChrTypeFromString(ty= pe))< 0) { >> + VIR_WARN("type =3D %s", type); >> virDomainReportError(VIR_ERR_XML_ERROR, >> _("unknown type presented to host for= character device: %s"), >> type); >> diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h >> index a3cb834..001bc46 100644 >> --- a/src/conf/domain_conf.h >> +++ b/src/conf/domain_conf.h >> @@ -59,6 +59,7 @@ enum virDomainVirtType { >> VIR_DOMAIN_VIRT_VBOX, >> VIR_DOMAIN_VIRT_ONE, >> VIR_DOMAIN_VIRT_PHYP, >> + VIR_DOMAIN_VIRT_KVMTOOL, >> >> VIR_DOMAIN_VIRT_LAST, >> }; > > IMHO this patch is not required. The domain type is refering to the > hypervisor used for the domain, which is still 'kvm'. What is differe= nt > here is just the userspace device model. If you look at the 3 differ= ent > Xen user spaces we support, all of them use sti= ll. > So just use here for kvmtool. > Make sense, agreed. Osier