From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [PATCH 2/2] i8254: Rework & fix interaction with HPET in legacy
 mode
Date: Sat, 10 Dec 2011 16:51:51 +0100
Message-ID: <4EE38017.5010001@web.de>
References: <cover.1323520118.git.jan.kiszka@web.de> <42a283294478be02e4f1dc5b0a78421030b51bbe.1323520118.git.jan.kiszka@web.de> <CAAu8pHuxCbvMoGTozxMTob9kT+gDkxDnBx-6+u1w3dGeJh6gxg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enig8D0D52E2AB7FD74DCBEFAD1B"
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	kvm <kvm@vger.kernel.org>
To: Blue Swirl <blauwirbel@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from fmmailgate02.web.de ([217.72.192.227]:43226 "EHLO
	fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750798Ab1LJPwA (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 10 Dec 2011 10:52:00 -0500
Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114])
	by fmmailgate02.web.de (Postfix) with ESMTP id 9AAEE1BB31E17
	for <kvm@vger.kernel.org>; Sat, 10 Dec 2011 16:51:58 +0100 (CET)
In-Reply-To: <CAAu8pHuxCbvMoGTozxMTob9kT+gDkxDnBx-6+u1w3dGeJh6gxg@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig8D0D52E2AB7FD74DCBEFAD1B
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 2011-12-10 16:49, Blue Swirl wrote:
>>
>> +ISADevice *pit_init(int base, qemu_irq irq)
>=20
> Please retain this function in pc.h, or even better, introduce i8254.h.=


No concerns about i8254.h, but this function does not qualify for static
inline.

>=20
>> +{
>> +    ISADevice *dev;
>> +
>> +    dev =3D isa_create("isa-pit");
>> +    qdev_prop_set_uint32(&dev->qdev, "iobase", base);
>> +    qdev_init_nofail(&dev->qdev);
>> +    qdev_connect_gpio_out(&dev->qdev, 0, irq);
>> +
>> +    return dev;
>> +}
>> +

Jan


--------------enig8D0D52E2AB7FD74DCBEFAD1B
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk7jgBsACgkQitSsb3rl5xSWkACdHWDqCoqdIOhuArzpWV/dNCm1
/KUAoNHR9Xnwz1Srq3zO4TFWUHrinP+U
=05/W
-----END PGP SIGNATURE-----

--------------enig8D0D52E2AB7FD74DCBEFAD1B--