From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 2/2] i8254: Rework & fix interaction with HPET in legacy mode Date: Sat, 10 Dec 2011 17:03:17 +0100 Message-ID: <4EE382C5.2000200@web.de> References: <42a283294478be02e4f1dc5b0a78421030b51bbe.1323520118.git.jan.kiszka@web.de> <4EE38017.5010001@web.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig6135F78582FECF5A0F67E32D" Cc: Anthony Liguori , qemu-devel , Avi Kivity , Marcelo Tosatti , kvm To: Blue Swirl Return-path: Received: from fmmailgate03.web.de ([217.72.192.234]:41475 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751134Ab1LJQDU (ORCPT ); Sat, 10 Dec 2011 11:03:20 -0500 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate03.web.de (Postfix) with ESMTP id B42DE1AB479DF for ; Sat, 10 Dec 2011 17:03:19 +0100 (CET) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6135F78582FECF5A0F67E32D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2011-12-10 16:54, Blue Swirl wrote: > On Sat, Dec 10, 2011 at 15:51, Jan Kiszka wrote: >> On 2011-12-10 16:49, Blue Swirl wrote: >>>> >>>> +ISADevice *pit_init(int base, qemu_irq irq) >>> >>> Please retain this function in pc.h, or even better, introduce i8254.= h. >> >> No concerns about i8254.h, but this function does not qualify for stat= ic >> inline. >=20 > The function is static inline in a header file not for performance > reasons, but to keep the instantiation separate from device internals. Not performance, footprint and header dependencies. You need to pull in all the stuff the inline function needs for everyone including the header that contains this function. That's messy. Even if the instantiation helper should not poke into the device model internals (and I don't want this to change as well), it belongs to the module that implements the device. We do the same with other fabric functions. Jan --------------enig6135F78582FECF5A0F67E32D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7jgsUACgkQitSsb3rl5xRRawCaAicEN5sD8ABQHQcwonJcWUv2 LoIAnj0rqee6WtoQ/yipkHeQ5DwS4f1g =o0iV -----END PGP SIGNATURE----- --------------enig6135F78582FECF5A0F67E32D--