From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [Android-virt] [PATCH v5 05/13] ARM: KVM: Inject IRQs and FIQs
 from userspace
Date: Mon, 12 Dec 2011 17:16:54 +0200
Message-ID: <4EE61AE6.6010600@redhat.com>
References: <20111211102403.21693.6887.stgit@localhost> <20111211102449.21693.12265.stgit@localhost> <4EE60173.6060502@redhat.com> <CAEDV+gLNNqAeTCXq5KUk0SsmjHPiUetBEfwO0zpVg8qQEAm=Ag@mail.gmail.com> <4EE614B5.3020003@redhat.com> <CAEDV+gLq5spqmiQZ_7okysen64B1Xd199r4hEVAp+N9FW6bYsw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Marc.Zyngier@arm.com, tech@virtualopensystems.com,
	android-virt@lists.cs.columbia.edu, kvm@vger.kernel.org
To: Christoffer Dall <c.dall@virtualopensystems.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:17169 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751026Ab1LLPRJ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 12 Dec 2011 10:17:09 -0500
In-Reply-To: <CAEDV+gLq5spqmiQZ_7okysen64B1Xd199r4hEVAp+N9FW6bYsw@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 12/12/2011 05:11 PM, Christoffer Dall wrote:
> >> If I should re-use the existing one, should I simply move it outside
> >> of __KVM_HAVE_IOAPIC?
> >
> > Protect it with __KVM_HAVE_IRQ_LINE so we don't leak unused tracepoints
> > for other archs.
> >
>
> ok. I used to be scared of touching your arch independent stuff, but
> maybe I should ease up there...

Yup.  We should also make more x86 code arch indepedent where possible.


-- 
error compiling committee.c: too many arguments to function