From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [Android-virt] [PATCH v5 05/13] ARM: KVM: Inject IRQs and FIQs
 from userspace
Date: Mon, 12 Dec 2011 19:40:38 +0200
Message-ID: <4EE63C96.9000602@redhat.com>
References: <20111211102403.21693.6887.stgit@localhost> <20111211102449.21693.12265.stgit@localhost> <4EE4C9D8.1010601@web.de> <CAFEAcA8dX6WeWQETbNTAOh-JeX5d87MzCG2+QZcv2pQM_J0yAA@mail.gmail.com> <CANM98q+Qi=LCyTphmHE4BrcKsrBeM0Q5hCLCqhL9juKGWaxmyg@mail.gmail.com> <CAFEAcA86ND4sS0XQ76Mc6p=mWJW3u36YHbuN96+3s83SjNotwg@mail.gmail.com> <-4744042178058961854@unknownmsgid> <CAFEAcA_=f27aCj+EBnf-Ej6GRQvO-W5gnjPUKNULpnZMGpLS8Q@mail.gmail.com> <CANM98q+6pgVo0R2MRrdo=y=BMasc9_gFF0cMxdRNMDwksqHLYw@mail.gmail.com> <CAFEAcA9cqAbS6VgchEcLjEjbsE_Arfqcs+WXvmOU3Y7hLCAK9Q@mail.gmail.com> <CAFEAcA8fVAyOzONHUX_W1Wfm3KXtSYMZKDfLC9kTEr9RPG5+kw@mail.gmail.com> <CAEDV+g+9TFzCiU19F7A0Hoqv=AA=roztAEaSia+o7HgLG7g25A@mail.gmail.com> <4EE53663.2050808@web.de> <CAFEAcA8fL-qnv1Pb6O2JMfgdvW2TF-HcYrSvMQcBUr91V5jSZg@mail.g
 mail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Jan Kiszka <jan.kiszka@web.de>,
	Christoffer Dall <c.dall@virtualopensystems.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"Marc.Zyngier@arm.com" <Marc.Zyngier@arm.com>,
	"android-virt@lists.cs.columbia.edu"
	<android-virt@lists.cs.columbia.edu>,
	"tech@virtualopensystems.com" <tech@virtualopensystems.com>
To: Peter Maydell <peter.maydell@linaro.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:58071 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751547Ab1LLRky (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 12 Dec 2011 12:40:54 -0500
In-Reply-To: <CAFEAcA8fL-qnv1Pb6O2JMfgdvW2TF-HcYrSvMQcBUr91V5jSZg@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 12/12/2011 06:31 PM, Peter Maydell wrote:
> On 11 December 2011 23:01, Jan Kiszka <jan.kiszka@web.de> wrote:
> > Enabling in-kernel irqchips usually means "switching worlds". So the
> > semantics of these particular IRQ inject interface details may change
> > without breaking anything.
> >
> > However, things might look different if there will be a need to inject
> > also the CPU IRQs directly, not only the irqchip inputs. In that case,
> > it may make some sense to reserve more space for interrupt types than
> > just one bit and use a common encoding scheme.
>
> I think with an in-kernel GIC model you'd only need to be able to set
> one of the (256 including internal-to-the-CPU inputs) GIC input lines;
> the GIC itself then connects directly to the vcpu IRQ and FIQ.
>
> So we could just have different semantics for the ioctl in the 'kernel
> GIC model enabled' config, as you suggest.

btw, since we use the KVM_IRQ_LINE ioctl, it may make sense to require
KVM_CREATE_IRQCHIP.  To create a kernel GIC model, just call
KVM_CREATE_IRQCHIP with a different parameter.  This removes an "except
for ARM" from the documentation.

-- 
error compiling committee.c: too many arguments to function