From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v5 12/13] ARM: KVM: Fix guest view of MPIDR Date: Mon, 12 Dec 2011 17:44:56 +0000 Message-ID: <4EE63D98.5040909@arm.com> References: <20111211102403.21693.6887.stgit@localhost> <20111211102536.21693.48826.stgit@localhost> <4EE6108E.8050001@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Cc: Avi Kivity , "android-virt@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , Catalin Marinas , "tech@virtualopensystems.com" , "peter.maydell@linaro.org" To: Christoffer Dall Return-path: Received: from service87.mimecast.com ([91.220.42.44]:49905 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751585Ab1LLRo6 convert rfc822-to-8bit (ORCPT ); Mon, 12 Dec 2011 12:44:58 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 12/12/11 17:39, Christoffer Dall wrote: > On Mon, Dec 12, 2011 at 9:32 AM, Avi Kivity wrote: >> On 12/11/2011 12:25 PM, Christoffer Dall wrote: >>> From: Marc Zyngier >>> >>> A guest may need to know which CPU it has booted on (and Linux does). >>> Now that we can run KVM on a SMP host, QEMU may be running on any >> >> s/QEMU/userspace/ >> >>> CPU. In that case, directly reading MPIDR will give an inconsistent >>> view on the guest CPU number (among other problems). >>> >>> The solution is to use the VMPIDR register, which is computed by >>> using the host MPIDR and overriding the low bits with KVM vcpu_id. >>> >>> Signed-off-by: Marc Zyngier >> >> Since you're posting the patch for (eventual) inclusion, you need to >> sign off as well. >> > I merged this into the world-switch patch. > > Can I add mark as signed-off-by in there then or should he really have > written that entire patch then. Marc? I don't mind if my name appears or not, really. As long as the functionality is in, I'm happy ;-). M. -- Jazz is not dead. It just smells funny...