From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v4 00/15] uq/master: Introduce basic irqchip support Date: Mon, 12 Dec 2011 19:59:18 +0200 Message-ID: <4EE640F6.9010809@redhat.com> References: <20111212163725.GA32142@amt.cnet> <4EE63123.101@siemens.com> <4EE63BCA.9040204@redhat.com> <4EE63D13.9070807@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , Lai Jiangshan , "kvm@vger.kernel.org" , "Michael S. Tsirkin" , Marcelo Tosatti , qemu-devel , Blue Swirl To: Jan Kiszka Return-path: In-Reply-To: <4EE63D13.9070807@siemens.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 12/12/2011 07:42 PM, Jan Kiszka wrote: > > It's a little late for this, but refactoring qemu-kvm in-tree and then > > splitting it into patches would have been easier. Let's try it this way > > for the next batch. > > I thought about this, but it definitely takes a clean, qemu-kvm free > base as start. The point is to design something free of all the legacy, > only looking at the other code base to extract the logic. If qemu-kvm was merged into qemu as is, then I'm sure you'd be able to refactor it into good shape (though there might be a little less motivation). > Moreover, there was and still is quite some upstream cleanup necessary, > and that never goes well with the delta of qemu-kvm. That's a good point. -- error compiling committee.c: too many arguments to function