* [PATCH 3.2] KVM: Make KVM_INTEL depend on CPU_SUP_INTEL
@ 2011-12-14 10:27 Avi Kivity
2011-12-14 13:11 ` Avi Kivity
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Avi Kivity @ 2011-12-14 10:27 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: kvm, Ingo Molnar, Randy Dunlap
PMU virtualization needs to talk to Intel-specific bits of perf; these are
only available when CPU_SUP_INTEL=y.
Fixes
arch/x86/built-in.o: In function `atomic_switch_perf_msrs':
vmx.c:(.text+0x6b1d4): undefined reference to `perf_guest_get_msrs'
Reported-by: Ingo Molnar <mingo@elte.hu>
Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Avi Kivity <avi@redhat.com>
---
arch/x86/kvm/Kconfig | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
index ff5790d..ca4d49e 100644
--- a/arch/x86/kvm/Kconfig
+++ b/arch/x86/kvm/Kconfig
@@ -52,6 +52,8 @@ config KVM
config KVM_INTEL
tristate "KVM for Intel processors support"
depends on KVM
+ # for perf_guest_get_msrs():
+ depends on CPU_SUP_INTEL
---help---
Provides support for KVM on Intel processors equipped with the VT
extensions.
--
1.7.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3.2] KVM: Make KVM_INTEL depend on CPU_SUP_INTEL
2011-12-14 10:27 [PATCH 3.2] KVM: Make KVM_INTEL depend on CPU_SUP_INTEL Avi Kivity
@ 2011-12-14 13:11 ` Avi Kivity
2011-12-16 16:22 ` Marcelo Tosatti
2011-12-16 18:26 ` Randy Dunlap
2 siblings, 0 replies; 4+ messages in thread
From: Avi Kivity @ 2011-12-14 13:11 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: kvm, Ingo Molnar, Randy Dunlap
On 12/14/2011 12:27 PM, Avi Kivity wrote:
> PMU virtualization needs to talk to Intel-specific bits of perf; these are
> only available when CPU_SUP_INTEL=y.
>
> Fixes
>
> arch/x86/built-in.o: In function `atomic_switch_perf_msrs':
> vmx.c:(.text+0x6b1d4): undefined reference to `perf_guest_get_msrs'
>
>
Actually, it's for 3.3. Don't know what I was thinking.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3.2] KVM: Make KVM_INTEL depend on CPU_SUP_INTEL
2011-12-14 10:27 [PATCH 3.2] KVM: Make KVM_INTEL depend on CPU_SUP_INTEL Avi Kivity
2011-12-14 13:11 ` Avi Kivity
@ 2011-12-16 16:22 ` Marcelo Tosatti
2011-12-16 18:26 ` Randy Dunlap
2 siblings, 0 replies; 4+ messages in thread
From: Marcelo Tosatti @ 2011-12-16 16:22 UTC (permalink / raw)
To: Avi Kivity; +Cc: kvm, Ingo Molnar, Randy Dunlap
On Wed, Dec 14, 2011 at 12:27:47PM +0200, Avi Kivity wrote:
> PMU virtualization needs to talk to Intel-specific bits of perf; these are
> only available when CPU_SUP_INTEL=y.
>
> Fixes
>
> arch/x86/built-in.o: In function `atomic_switch_perf_msrs':
> vmx.c:(.text+0x6b1d4): undefined reference to `perf_guest_get_msrs'
>
> Reported-by: Ingo Molnar <mingo@elte.hu>
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Avi Kivity <avi@redhat.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3.2] KVM: Make KVM_INTEL depend on CPU_SUP_INTEL
2011-12-14 10:27 [PATCH 3.2] KVM: Make KVM_INTEL depend on CPU_SUP_INTEL Avi Kivity
2011-12-14 13:11 ` Avi Kivity
2011-12-16 16:22 ` Marcelo Tosatti
@ 2011-12-16 18:26 ` Randy Dunlap
2 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2011-12-16 18:26 UTC (permalink / raw)
To: Avi Kivity; +Cc: Marcelo Tosatti, kvm, Ingo Molnar
On 12/14/2011 02:27 AM, Avi Kivity wrote:
> PMU virtualization needs to talk to Intel-specific bits of perf; these are
> only available when CPU_SUP_INTEL=y.
>
> Fixes
>
> arch/x86/built-in.o: In function `atomic_switch_perf_msrs':
> vmx.c:(.text+0x6b1d4): undefined reference to `perf_guest_get_msrs'
>
> Reported-by: Ingo Molnar <mingo@elte.hu>
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Avi Kivity <avi@redhat.com>
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Thanks.
> ---
> arch/x86/kvm/Kconfig | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> index ff5790d..ca4d49e 100644
> --- a/arch/x86/kvm/Kconfig
> +++ b/arch/x86/kvm/Kconfig
> @@ -52,6 +52,8 @@ config KVM
> config KVM_INTEL
> tristate "KVM for Intel processors support"
> depends on KVM
> + # for perf_guest_get_msrs():
> + depends on CPU_SUP_INTEL
> ---help---
> Provides support for KVM on Intel processors equipped with the VT
> extensions.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-12-17 15:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-14 10:27 [PATCH 3.2] KVM: Make KVM_INTEL depend on CPU_SUP_INTEL Avi Kivity
2011-12-14 13:11 ` Avi Kivity
2011-12-16 16:22 ` Marcelo Tosatti
2011-12-16 18:26 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).