From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: [PATCH 2/8] KVM: MMU: set the dirty bit for the upper shadow page Date: Fri, 16 Dec 2011 18:14:24 +0800 Message-ID: <4EEB1A00.8090707@linux.vnet.ibm.com> References: <4EEB19AF.5070501@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , LKML , KVM To: Xiao Guangrong Return-path: Received: from e28smtp06.in.ibm.com ([122.248.162.6]:54543 "EHLO e28smtp06.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270Ab1LPKOc (ORCPT ); Fri, 16 Dec 2011 05:14:32 -0500 Received: from /spool/local by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 16 Dec 2011 15:44:29 +0530 In-Reply-To: <4EEB19AF.5070501@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Upper page do not need to be tracked the status bit, it is safe to set the dirty and let cpu to happily prefetch it Signed-off-by: Xiao Guangrong --- arch/x86/kvm/mmu.c | 13 +++++-------- 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index 6913a16..a2d28aa 100644 --- a/arch/x86/kvm/mmu.c +++ b/arch/x86/kvm/mmu.c @@ -150,6 +150,9 @@ module_param(dbg, bool, 0644); #define SPTE_HOST_WRITEABLE (1ULL << PT_FIRST_AVAIL_BITS_SHIFT) #define SHADOW_PT_INDEX(addr, level) PT64_INDEX(addr, level) +#define SHADOW_PAGE_TABLE \ + (PT_PRESENT_MASK | PT_WRITABLE_MASK | shadow_user_mask | \ + shadow_x_mask | shadow_accessed_mask | shadow_dirty_mask) static bool sp_is_unsync(struct kvm_mmu_page *sp) { @@ -1808,9 +1811,7 @@ static void link_shadow_page(u64 *sptep, struct kvm_mmu_page *sp) { u64 spte; - spte = __pa(sp->spt) - | PT_PRESENT_MASK | PT_ACCESSED_MASK - | PT_WRITABLE_MASK | PT_USER_MASK; + spte = __pa(sp->spt) | SHADOW_PAGE_TABLE; mmu_spte_set(sptep, spte); } @@ -2497,11 +2498,7 @@ static int __direct_map(struct kvm_vcpu *vcpu, gpa_t v, int write, return -ENOMEM; } - mmu_spte_set(iterator.sptep, - __pa(sp->spt) - | PT_PRESENT_MASK | PT_WRITABLE_MASK - | shadow_user_mask | shadow_x_mask - | shadow_accessed_mask); + link_shadow_page(iterator.sptep, sp); } } return emulate; -- 1.7.7.4