From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/3] QEMU kvm/i386 : Adding KICK_VCPU capability support in i386 target. Date: Mon, 19 Dec 2011 15:59:06 +0200 Message-ID: <4EEF432A.3030905@redhat.com> References: <20111204182541.28487.68163.sendpatchset@oc5400248562.ibm.com> <20111204182622.28487.98656.sendpatchset@oc5400248562.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, Jan Kiszka , Raghavendra K T , Srivatsa Vaddagiri , qemu-devel@nongnu.org, Suzuki Poulose To: Alexander Graf Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 12/19/2011 03:54 PM, Alexander Graf wrote: > On 04.12.2011, at 19:26, Raghavendra K T wrote: > > > Extend the KVM Hypervisor to enable KICK_VCPU feature that allows > > a vcpu to kick the halted vcpu to continue with execution in PV ticket > > spinlock. > > > > Signed-off-by: Srivatsa Vaddagiri > > Signed-off-by: Raghavendra K T > > --- > > diff --git a/target-i386/kvm.c b/target-i386/kvm.c > > index 5bfc21f..69bce21 100644 > > --- a/target-i386/kvm.c > > +++ b/target-i386/kvm.c > > @@ -97,6 +97,7 @@ struct kvm_para_features { > > { KVM_CAP_NOP_IO_DELAY, KVM_FEATURE_NOP_IO_DELAY }, > > { KVM_CAP_PV_MMU, KVM_FEATURE_MMU_OP }, > > { KVM_CAP_ASYNC_PF, KVM_FEATURE_ASYNC_PF }, > > + { KVM_CAP_KICK_VCPU, KVM_FEATURE_KICK_VCPU }, > > So this is handled in the kernel? Who enables the feature? Is it always on? Why bother with it in user space at all then? Backwards compatibility -- error compiling committee.c: too many arguments to function