From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [PATCH v5 07/16] apic: Open-code timer save/restore
Date: Mon, 19 Dec 2011 16:21:47 -0600
Message-ID: <4EEFB8FB.3030105@codemonkey.ws>
References: <cover.1323952402.git.jan.kiszka@siemens.com>
	<61e59db37279bb3834b996c84e9a0523638f5e35.1323952403.git.jan.kiszka@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Anthony Liguori <aliguori@us.ibm.com>, kvm@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel <qemu-devel@nongnu.org>,
	Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <61e59db37279bb3834b996c84e9a0523638f5e35.1323952403.git.jan.kiszka@siemens.com>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
List-Id: kvm.vger.kernel.org

On 12/15/2011 06:33 AM, Jan Kiszka wrote:
> To enable migration between accelerated and non-accelerated APIC models,
> we will need to handle the timer saving and restoring specially and can
> no longer rely on the automatics of VMSTATE_TIMER. Specifically,
> accelerated model will not start any QEMUTimer.
>
> This patch therefore factors out the generic bits into apic_next_timer
> and introduces a post-load callback that can be implemented differently
> by both models.
>
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>

So you basically want the timer to be a dummy field for the in-kernel apic?

Can you fix this up in a pre-save routine (put QEMUTimer into a state where 
there isn't an event pending)?

Regards,

Anthony Liguori