From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v5 07/16] apic: Open-code timer save/restore Date: Tue, 20 Dec 2011 00:45:22 +0100 Message-ID: <4EEFCC92.9030300@web.de> References: <61e59db37279bb3834b996c84e9a0523638f5e35.1323952403.git.jan.kiszka@siemens.com> <4EEFB8FB.3030105@codemonkey.ws> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig3B53F8693F6822058FF2A25A" Cc: Anthony Liguori , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcelo Tosatti , qemu-devel , Blue Swirl , Avi Kivity To: Anthony Liguori Return-path: Received: from fmmailgate01.web.de ([217.72.192.221]:38909 "EHLO fmmailgate01.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751610Ab1LSXpa (ORCPT ); Mon, 19 Dec 2011 18:45:30 -0500 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate01.web.de (Postfix) with ESMTP id 9C2731A5C5963 for ; Tue, 20 Dec 2011 00:45:28 +0100 (CET) In-Reply-To: <4EEFB8FB.3030105@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3B53F8693F6822058FF2A25A Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-12-19 23:21, Anthony Liguori wrote: > On 12/15/2011 06:33 AM, Jan Kiszka wrote: >> To enable migration between accelerated and non-accelerated APIC model= s, >> we will need to handle the timer saving and restoring specially and ca= n >> no longer rely on the automatics of VMSTATE_TIMER. Specifically, >> accelerated model will not start any QEMUTimer. >> >> This patch therefore factors out the generic bits into apic_next_timer= >> and introduces a post-load callback that can be implemented differentl= y >> by both models. >> >> Signed-off-by: Jan Kiszka >=20 > So you basically want the timer to be a dummy field for the in-kernel a= pic? >=20 > Can you fix this up in a pre-save routine (put QEMUTimer into a state > where there isn't an event pending)? It is not a dummy field, it contains the proper state in both cases. We just need to convert it to an open-coded state to avoid the QEMUTimer restoration magic in the in-kernel case (where there must be no QEMUTimer= ). Jan --------------enig3B53F8693F6822058FF2A25A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7vzJMACgkQitSsb3rl5xTW2QCfUkzQSBgFVBrfqGFXnmgPM88A q/YAoMC2puWUDFxVS8o9g2zB+JXKDQbC =4jMV -----END PGP SIGNATURE----- --------------enig3B53F8693F6822058FF2A25A--