From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [PATCH v5 00/16] uq/master: Introduce basic
 irqchip support
Date: Tue, 20 Dec 2011 00:49:05 +0100
Message-ID: <4EEFCD71.5040603@web.de>
References: <cover.1323952402.git.jan.kiszka@siemens.com>
	<20111219211737.GA17469@amt.cnet> <4EEFB9AE.7050309@codemonkey.ws>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig25E0B98AA850F99F7831EDAA"
Cc: Anthony Liguori <aliguori@us.ibm.com>, Lai Jiangshan <laijs@cn.fujitsu.com>,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel <qemu-devel@nongnu.org>,
	Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <4EEFB9AE.7050309@codemonkey.ws>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
List-Id: kvm.vger.kernel.org

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig25E0B98AA850F99F7831EDAA
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 2011-12-19 23:24, Anthony Liguori wrote:
> On 12/19/2011 03:17 PM, Marcelo Tosatti wrote:
>>
>> Anthony,
>>
>> Can you please review&  ACK?
>>
>> You could even apply directly but well do a kvm-autotest run through
>> uq/master. Still, your review is needed.
>=20
> Overall, it looks good except for the backend/frontend split.  This
> should be done in terms of qdev inheritance.

I cannot follow your idea here yet. There is no inheritance as we end up
with only a single class that permutes (selects a different backend) on
creation. I'm not sure how to model two classes that will still only
mean a single qdev registration.

Jan


--------------enig25E0B98AA850F99F7831EDAA
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk7vzXEACgkQitSsb3rl5xSaGgCeIOCvzBzxk+FHaTDUrKKGObai
tHgAnigPJCkX1NAS31MWGQ5ksuqiN8aB
=dxbs
-----END PGP SIGNATURE-----

--------------enig25E0B98AA850F99F7831EDAA--