From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support Date: Mon, 19 Dec 2011 18:32:41 -0600 Message-ID: <4EEFD7A9.3050007@codemonkey.ws> References: <20111219211737.GA17469@amt.cnet> <4EEFB9AE.7050309@codemonkey.ws> <4EEFCD71.5040603@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Lai Jiangshan , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcelo Tosatti , qemu-devel , Blue Swirl , Avi Kivity To: Jan Kiszka Return-path: Received: from mail-yw0-f46.google.com ([209.85.213.46]:57164 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753181Ab1LTAco (ORCPT ); Mon, 19 Dec 2011 19:32:44 -0500 Received: by yhr47 with SMTP id 47so4401752yhr.19 for ; Mon, 19 Dec 2011 16:32:44 -0800 (PST) In-Reply-To: <4EEFCD71.5040603@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 12/19/2011 05:49 PM, Jan Kiszka wrote: > On 2011-12-19 23:24, Anthony Liguori wrote: >> On 12/19/2011 03:17 PM, Marcelo Tosatti wrote: >>> >>> Anthony, >>> >>> Can you please review& ACK? >>> >>> You could even apply directly but well do a kvm-autotest run through >>> uq/master. Still, your review is needed. >> >> Overall, it looks good except for the backend/frontend split. This >> should be done in terms of qdev inheritance. > > I cannot follow your idea here yet. There is no inheritance as we end up > with only a single class that permutes (selects a different backend) on > creation. I'm not sure how to model two classes that will still only > mean a single qdev registration. See other reply in thread. We should model this as two separate qdev devices. We can avoid regressing migration in qemu-kvm by just having a common vmstate name. apic is a no-user device so there's no way that changing the name of it in qemu-kvm can affect users. Regards, Anthony Liguori > > Jan >