From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support Date: Tue, 20 Dec 2011 01:37:37 +0100 Message-ID: <4EEFD8D1.3060707@web.de> References: <20111219211737.GA17469@amt.cnet> <4EEFB9AE.7050309@codemonkey.ws> <4EEFCD71.5040603@web.de> <4EEFD7A9.3050007@codemonkey.ws> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig2C23A3E644571501918D702F" Cc: Lai Jiangshan , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcelo Tosatti , qemu-devel , Blue Swirl , Avi Kivity To: Anthony Liguori Return-path: Received: from fmmailgate01.web.de ([217.72.192.221]:42278 "EHLO fmmailgate01.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752335Ab1LTAhm (ORCPT ); Mon, 19 Dec 2011 19:37:42 -0500 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate01.web.de (Postfix) with ESMTP id 374DF1A5CB726 for ; Tue, 20 Dec 2011 01:37:41 +0100 (CET) In-Reply-To: <4EEFD7A9.3050007@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2C23A3E644571501918D702F Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-12-20 01:32, Anthony Liguori wrote: > On 12/19/2011 05:49 PM, Jan Kiszka wrote: >> On 2011-12-19 23:24, Anthony Liguori wrote: >>> On 12/19/2011 03:17 PM, Marcelo Tosatti wrote: >>>> >>>> Anthony, >>>> >>>> Can you please review& ACK? >>>> >>>> You could even apply directly but well do a kvm-autotest run through= >>>> uq/master. Still, your review is needed. >>> >>> Overall, it looks good except for the backend/frontend split. This >>> should be done in terms of qdev inheritance. >> >> I cannot follow your idea here yet. There is no inheritance as we end = up >> with only a single class that permutes (selects a different backend) o= n >> creation. I'm not sure how to model two classes that will still only >> mean a single qdev registration. >=20 > See other reply in thread. >=20 > We should model this as two separate qdev devices. We can avoid > regressing migration in qemu-kvm by just having a common vmstate name. >=20 > apic is a no-user device so there's no way that changing the name of it= > in qemu-kvm can affect users. Look down http://thread.gmane.org/gmane.comp.emulators.kvm.devel/82598 for the discussion of that model. Jan --------------enig2C23A3E644571501918D702F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7v2NEACgkQitSsb3rl5xTS6gCeOIB6S9OFcpssdGLchZFdjggi e3AAn301nFOyDmbp/Ak6NuSM7JVokRZd =sHSo -----END PGP SIGNATURE----- --------------enig2C23A3E644571501918D702F--