From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matt Evans <matt@ozlabs.org>
Subject: Re: [PATCH V2 4/6] kvm tools: Add PPC64 XICS interrupt controller
 support
Date: Tue, 20 Dec 2011 12:16:40 +1100
Message-ID: <4EEFE1F8.9040501@ozlabs.org>
References: <1323760250-13237-1-git-send-email-matt@ozlabs.org> <1323760250-13237-5-git-send-email-matt@ozlabs.org> <20111214023555.GD21214@truffala.fritz.box>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, penberg@kernel.org,
	asias.hejun@gmail.com, levinsasha928@gmail.com, gorcunov@gmail.com,
	aik@ozlabs.ru
To: David Gibson <david@gibson.dropbear.id.au>
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <20111214023555.GD21214@truffala.fritz.box>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

Hi David,

On 14/12/11 13:35, David Gibson wrote:
> On Tue, Dec 13, 2011 at 06:10:48PM +1100, Matt Evans wrote:
>> This patch adds XICS emulation code (heavily borrowed from QEMU), and wires
>> this into kvm_cpu__irq() to fire a CPU IRQ via KVM.  A device tree entry is
>> also added.  IPIs work, xics_alloc_irqnum() is added to allocate an external
>> IRQ (which will later be used by the PHB PCI code) and finally, kvm__irq_line()
>> can be called to raise an IRQ on XICS.\
> 
> Hrm, looks like you took a somewhat old version of xics.c from qemu.
> It dangerously uses the same variable names for global irq numbers and
> numbers local to one ics unit.  It used to have at least one bug
> caused by confusing the two, which I'm not sure if you've also copied.

Just had a look at the diffs between this and hw/xics.c from the master branch
in your qemu-impreza.git (which I based the kvmtool stuff on) and I can't see
anything standing out.

Is there a particular commit/patch/variable name you have in mind that I can
search for?


Thanks!


Matt