From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] kvm: Remove ability to assign a device without iommu support Date: Tue, 20 Dec 2011 11:14:11 +0200 Message-ID: <4EF051E3.20101@redhat.com> References: <20111220030826.11829.9141.stgit@bling.home> <20111220031947.11829.66292.stgit@bling.home> <1324370959.22797.3.camel@lappy> <4EF04F54.9010500@siemens.com> <1324372128.22797.6.camel@lappy> <4EF0516F.2030102@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Sasha Levin , Alex Williamson , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:18153 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752948Ab1LTJOS (ORCPT ); Tue, 20 Dec 2011 04:14:18 -0500 In-Reply-To: <4EF0516F.2030102@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/20/2011 11:12 AM, Jan Kiszka wrote: > > > > Well, Alex suggested skipping deprecation period because there are > > currently no users of KVM_ASSIGN_PCI_DEVICE without > > KVM_DEV_ASSIGN_ENABLE_IOMMU, so it should be fine to just make it the > > default behavior, no? > > This iommu-less mode used to "work" for older qemu-kvm version, and I > think it should still do. Though it makes no sense, I fully agree. > It only worked for special kernels that allowed 1:1 gpa/hpa mappings, IIRC. -- error compiling committee.c: too many arguments to function