* [PATCH 1/2] kvm tools: Remove lkvm alias vm in 'make clean'
@ 2011-12-21 8:07 Asias He
2011-12-21 8:07 ` [PATCH 2/2] kvm tools: Improve './lkvm {pause,resume}'s output Asias He
2011-12-21 9:14 ` [PATCH 1/2] kvm tools: Remove lkvm alias vm in 'make clean' Wanlong Gao
0 siblings, 2 replies; 6+ messages in thread
From: Asias He @ 2011-12-21 8:07 UTC (permalink / raw)
To: Pekka Enberg; +Cc: Sasha Levin, Cyrill Gorcunov, Ingo Molnar, kvm, Asias He
lkvm alias vm is not removed in 'make clean'.
This patch fixes this.
Signed-off-by: Asias He <asias.hejun@gmail.com>
---
tools/kvm/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/kvm/Makefile b/tools/kvm/Makefile
index ce3df65..d54fa47 100644
--- a/tools/kvm/Makefile
+++ b/tools/kvm/Makefile
@@ -325,7 +325,7 @@ clean:
$(Q) rm -f x86/bios/bios-rom.h
$(Q) rm -f tests/boot/boot_test.iso
$(Q) rm -rf tests/boot/rootfs/
- $(Q) rm -f $(DEPS) $(OBJS) $(PROGRAM) $(GUEST_INIT) $(GUEST_INIT_S2)
+ $(Q) rm -f $(DEPS) $(OBJS) $(PROGRAM) $(PROGRAM_ALIAS) $(GUEST_INIT) $(GUEST_INIT_S2)
$(Q) rm -f cscope.*
$(Q) rm -f $(KVM_INCLUDE)/common-cmds.h
$(Q) rm -f KVMTOOLS-VERSION-FILE
--
1.7.7.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] kvm tools: Improve './lkvm {pause,resume}'s output
2011-12-21 8:07 [PATCH 1/2] kvm tools: Remove lkvm alias vm in 'make clean' Asias He
@ 2011-12-21 8:07 ` Asias He
2011-12-21 9:14 ` Wanlong Gao
2011-12-21 9:14 ` [PATCH 1/2] kvm tools: Remove lkvm alias vm in 'make clean' Wanlong Gao
1 sibling, 1 reply; 6+ messages in thread
From: Asias He @ 2011-12-21 8:07 UTC (permalink / raw)
To: Pekka Enberg; +Cc: Sasha Levin, Cyrill Gorcunov, Ingo Molnar, kvm, Asias He
./lkvm {pause,resume} do not give any feedback to user who uses these
commands in the console where the command run.
This patch makes the command output in the command console instead of
guest console.
Signed-off-by: Asias He <asias.hejun@gmail.com>
---
tools/kvm/builtin-pause.c | 2 ++
tools/kvm/builtin-resume.c | 2 ++
tools/kvm/builtin-run.c | 1 -
3 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/tools/kvm/builtin-pause.c b/tools/kvm/builtin-pause.c
index 107641c..a8e805e 100644
--- a/tools/kvm/builtin-pause.c
+++ b/tools/kvm/builtin-pause.c
@@ -54,6 +54,8 @@ static int do_pause(const char *name, int sock)
if (r < 0)
return r;
+ printf("Guest %s paused\n", name);
+
return 0;
}
diff --git a/tools/kvm/builtin-resume.c b/tools/kvm/builtin-resume.c
index 7b87f59..fd00763 100644
--- a/tools/kvm/builtin-resume.c
+++ b/tools/kvm/builtin-resume.c
@@ -54,6 +54,8 @@ static int do_resume(const char *name, int sock)
if (r < 0)
return r;
+ printf("Guest %s resumed\n", name);
+
return 0;
}
diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c
index fac274c..8f512c3 100644
--- a/tools/kvm/builtin-run.c
+++ b/tools/kvm/builtin-run.c
@@ -515,7 +515,6 @@ static void handle_pause(int fd, u32 type, u32 len, u8 *msg)
return;
is_paused = !is_paused;
- pr_info("Guest %s\n", is_paused ? "paused" : "resumed");
}
static void handle_debug(int fd, u32 type, u32 len, u8 *msg)
--
1.7.7.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] kvm tools: Improve './lkvm {pause,resume}'s output
2011-12-21 8:07 ` [PATCH 2/2] kvm tools: Improve './lkvm {pause,resume}'s output Asias He
@ 2011-12-21 9:14 ` Wanlong Gao
2011-12-22 2:15 ` Asias He
0 siblings, 1 reply; 6+ messages in thread
From: Wanlong Gao @ 2011-12-21 9:14 UTC (permalink / raw)
To: Asias He; +Cc: Pekka Enberg, Sasha Levin, Cyrill Gorcunov, Ingo Molnar, kvm
On 12/21/2011 04:07 PM, Asias He wrote:
> ./lkvm {pause,resume} do not give any feedback to user who uses these
> commands in the console where the command run.
>
> This patch makes the command output in the command console instead of
> guest console.
I's like notice users in both sides, so don't remove the pr_info?
Thanks
-Wanlong Gao
>
> Signed-off-by: Asias He <asias.hejun@gmail.com>
> ---
> tools/kvm/builtin-pause.c | 2 ++
> tools/kvm/builtin-resume.c | 2 ++
> tools/kvm/builtin-run.c | 1 -
> 3 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/tools/kvm/builtin-pause.c b/tools/kvm/builtin-pause.c
> index 107641c..a8e805e 100644
> --- a/tools/kvm/builtin-pause.c
> +++ b/tools/kvm/builtin-pause.c
> @@ -54,6 +54,8 @@ static int do_pause(const char *name, int sock)
> if (r < 0)
> return r;
>
> + printf("Guest %s paused\n", name);
> +
> return 0;
> }
>
> diff --git a/tools/kvm/builtin-resume.c b/tools/kvm/builtin-resume.c
> index 7b87f59..fd00763 100644
> --- a/tools/kvm/builtin-resume.c
> +++ b/tools/kvm/builtin-resume.c
> @@ -54,6 +54,8 @@ static int do_resume(const char *name, int sock)
> if (r < 0)
> return r;
>
> + printf("Guest %s resumed\n", name);
> +
> return 0;
> }
>
> diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c
> index fac274c..8f512c3 100644
> --- a/tools/kvm/builtin-run.c
> +++ b/tools/kvm/builtin-run.c
> @@ -515,7 +515,6 @@ static void handle_pause(int fd, u32 type, u32 len, u8 *msg)
> return;
>
> is_paused = !is_paused;
> - pr_info("Guest %s\n", is_paused ? "paused" : "resumed");
> }
>
> static void handle_debug(int fd, u32 type, u32 len, u8 *msg)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] kvm tools: Remove lkvm alias vm in 'make clean'
2011-12-21 8:07 [PATCH 1/2] kvm tools: Remove lkvm alias vm in 'make clean' Asias He
2011-12-21 8:07 ` [PATCH 2/2] kvm tools: Improve './lkvm {pause,resume}'s output Asias He
@ 2011-12-21 9:14 ` Wanlong Gao
1 sibling, 0 replies; 6+ messages in thread
From: Wanlong Gao @ 2011-12-21 9:14 UTC (permalink / raw)
To: Asias He; +Cc: Pekka Enberg, Sasha Levin, Cyrill Gorcunov, Ingo Molnar, kvm
On 12/21/2011 04:07 PM, Asias He wrote:
> lkvm alias vm is not removed in 'make clean'.
> This patch fixes this.
>
> Signed-off-by: Asias He <asias.hejun@gmail.com>
Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> ---
> tools/kvm/Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/kvm/Makefile b/tools/kvm/Makefile
> index ce3df65..d54fa47 100644
> --- a/tools/kvm/Makefile
> +++ b/tools/kvm/Makefile
> @@ -325,7 +325,7 @@ clean:
> $(Q) rm -f x86/bios/bios-rom.h
> $(Q) rm -f tests/boot/boot_test.iso
> $(Q) rm -rf tests/boot/rootfs/
> - $(Q) rm -f $(DEPS) $(OBJS) $(PROGRAM) $(GUEST_INIT) $(GUEST_INIT_S2)
> + $(Q) rm -f $(DEPS) $(OBJS) $(PROGRAM) $(PROGRAM_ALIAS) $(GUEST_INIT) $(GUEST_INIT_S2)
> $(Q) rm -f cscope.*
> $(Q) rm -f $(KVM_INCLUDE)/common-cmds.h
> $(Q) rm -f KVMTOOLS-VERSION-FILE
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] kvm tools: Improve './lkvm {pause,resume}'s output
2011-12-21 9:14 ` Wanlong Gao
@ 2011-12-22 2:15 ` Asias He
2011-12-22 6:52 ` Pekka Enberg
0 siblings, 1 reply; 6+ messages in thread
From: Asias He @ 2011-12-22 2:15 UTC (permalink / raw)
To: gaowanlong; +Cc: Pekka Enberg, Sasha Levin, Cyrill Gorcunov, Ingo Molnar, kvm
On 12/21/2011 05:14 PM, Wanlong Gao wrote:
> On 12/21/2011 04:07 PM, Asias He wrote:
>
>> ./lkvm {pause,resume} do not give any feedback to user who uses these
>> commands in the console where the command run.
>>
>> This patch makes the command output in the command console instead of
>> guest console.
>
>
> I's like notice users in both sides, so don't remove the pr_info?
It's quite annoying to print in the guest side. And we can reflect the
guest status in 'lkvm list' now. So I'd like to remove the guest side
notification.
>
>
> Thanks
> -Wanlong Gao
>
>>
>> Signed-off-by: Asias He <asias.hejun@gmail.com>
>> ---
>> tools/kvm/builtin-pause.c | 2 ++
>> tools/kvm/builtin-resume.c | 2 ++
>> tools/kvm/builtin-run.c | 1 -
>> 3 files changed, 4 insertions(+), 1 deletions(-)
>>
>> diff --git a/tools/kvm/builtin-pause.c b/tools/kvm/builtin-pause.c
>> index 107641c..a8e805e 100644
>> --- a/tools/kvm/builtin-pause.c
>> +++ b/tools/kvm/builtin-pause.c
>> @@ -54,6 +54,8 @@ static int do_pause(const char *name, int sock)
>> if (r < 0)
>> return r;
>>
>> + printf("Guest %s paused\n", name);
>> +
>> return 0;
>> }
>>
>> diff --git a/tools/kvm/builtin-resume.c b/tools/kvm/builtin-resume.c
>> index 7b87f59..fd00763 100644
>> --- a/tools/kvm/builtin-resume.c
>> +++ b/tools/kvm/builtin-resume.c
>> @@ -54,6 +54,8 @@ static int do_resume(const char *name, int sock)
>> if (r < 0)
>> return r;
>>
>> + printf("Guest %s resumed\n", name);
>> +
>> return 0;
>> }
>>
>> diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c
>> index fac274c..8f512c3 100644
>> --- a/tools/kvm/builtin-run.c
>> +++ b/tools/kvm/builtin-run.c
>> @@ -515,7 +515,6 @@ static void handle_pause(int fd, u32 type, u32 len, u8 *msg)
>> return;
>>
>> is_paused = !is_paused;
>> - pr_info("Guest %s\n", is_paused ? "paused" : "resumed");
>> }
>>
>> static void handle_debug(int fd, u32 type, u32 len, u8 *msg)
>
>
>
--
Asias He
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] kvm tools: Improve './lkvm {pause,resume}'s output
2011-12-22 2:15 ` Asias He
@ 2011-12-22 6:52 ` Pekka Enberg
0 siblings, 0 replies; 6+ messages in thread
From: Pekka Enberg @ 2011-12-22 6:52 UTC (permalink / raw)
To: Asias He; +Cc: gaowanlong, Sasha Levin, Cyrill Gorcunov, Ingo Molnar, kvm
On Thu, 22 Dec 2011, Asias He wrote:
> It's quite annoying to print in the guest side. And we can reflect the
> guest status in 'lkvm list' now. So I'd like to remove the guest side
> notification.
Sure. It's not going to work either once we start supporting X. I'm pretty
sure we'd need to get the guest kernel involved in some structured way to
inject notifications from the host.
Pekka
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-12-22 6:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-21 8:07 [PATCH 1/2] kvm tools: Remove lkvm alias vm in 'make clean' Asias He
2011-12-21 8:07 ` [PATCH 2/2] kvm tools: Improve './lkvm {pause,resume}'s output Asias He
2011-12-21 9:14 ` Wanlong Gao
2011-12-22 2:15 ` Asias He
2011-12-22 6:52 ` Pekka Enberg
2011-12-21 9:14 ` [PATCH 1/2] kvm tools: Remove lkvm alias vm in 'make clean' Wanlong Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).