From mboxrd@z Thu Jan  1 00:00:00 1970
From: Asias He <asias.hejun@gmail.com>
Subject: Re: [PATCH 2/2] kvm tools: Improve './lkvm {pause,resume}'s output
Date: Thu, 22 Dec 2011 10:15:59 +0800
Message-ID: <4EF292DF.2060407@gmail.com>
References: <1324454842-28139-1-git-send-email-asias.hejun@gmail.com> <1324454842-28139-2-git-send-email-asias.hejun@gmail.com> <4EF1A362.4030508@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Pekka Enberg <penberg@kernel.org>,
	Sasha Levin <levinsasha928@gmail.com>,
	Cyrill Gorcunov <gorcunov@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, kvm@vger.kernel.org
To: gaowanlong@cn.fujitsu.com
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-iy0-f174.google.com ([209.85.210.174]:65225 "EHLO
	mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752446Ab1LVCRd (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 21 Dec 2011 21:17:33 -0500
Received: by iaeh11 with SMTP id h11so12750686iae.19
        for <kvm@vger.kernel.org>; Wed, 21 Dec 2011 18:17:33 -0800 (PST)
In-Reply-To: <4EF1A362.4030508@cn.fujitsu.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 12/21/2011 05:14 PM, Wanlong Gao wrote:
> On 12/21/2011 04:07 PM, Asias He wrote:
> 
>> ./lkvm {pause,resume} do not give any feedback to user who uses these
>> commands in the console where the command run.
>>
>> This patch makes the command output in the command console instead of
>> guest console.
> 
> 
> I's like notice users in both sides, so don't remove the pr_info?

It's quite annoying to print in the guest side. And we can reflect the
guest status in 'lkvm list' now. So I'd like to remove the guest side
notification.

> 
> 
> Thanks
> -Wanlong Gao 
> 
>>
>> Signed-off-by: Asias He <asias.hejun@gmail.com>
>> ---
>>  tools/kvm/builtin-pause.c  |    2 ++
>>  tools/kvm/builtin-resume.c |    2 ++
>>  tools/kvm/builtin-run.c    |    1 -
>>  3 files changed, 4 insertions(+), 1 deletions(-)
>>
>> diff --git a/tools/kvm/builtin-pause.c b/tools/kvm/builtin-pause.c
>> index 107641c..a8e805e 100644
>> --- a/tools/kvm/builtin-pause.c
>> +++ b/tools/kvm/builtin-pause.c
>> @@ -54,6 +54,8 @@ static int do_pause(const char *name, int sock)
>>  	if (r < 0)
>>  		return r;
>>  
>> +	printf("Guest %s paused\n", name);
>> +
>>  	return 0;
>>  }
>>  
>> diff --git a/tools/kvm/builtin-resume.c b/tools/kvm/builtin-resume.c
>> index 7b87f59..fd00763 100644
>> --- a/tools/kvm/builtin-resume.c
>> +++ b/tools/kvm/builtin-resume.c
>> @@ -54,6 +54,8 @@ static int do_resume(const char *name, int sock)
>>  	if (r < 0)
>>  		return r;
>>  
>> +	printf("Guest %s resumed\n", name);
>> +
>>  	return 0;
>>  }
>>  
>> diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c
>> index fac274c..8f512c3 100644
>> --- a/tools/kvm/builtin-run.c
>> +++ b/tools/kvm/builtin-run.c
>> @@ -515,7 +515,6 @@ static void handle_pause(int fd, u32 type, u32 len, u8 *msg)
>>  		return;
>>  
>>  	is_paused = !is_paused;
>> -	pr_info("Guest %s\n", is_paused ? "paused" : "resumed");
>>  }
>>  
>>  static void handle_debug(int fd, u32 type, u32 len, u8 *msg)
> 
> 
> 


-- 
Asias He