Re: [patch 3/3] kvm-s390: provide general purpose registers via kvm_run

[Avi Kivity <avi@redhat.com>]

On 12/22/2011 01:56 PM, Christian Borntraeger wrote:
> From: Christian Borntraeger <borntraeger@de.ibm.com>
>
> The general purpose registers are often necessary to handle SIE exits.
> Avoid additional ioctls by providing the guest registers in the r/w 
> section of the kvm_run structure.
>

This is only needed for S390_UCONTROL?

>  
>  struct sync_rw_regs {
> +	__u64 gprs[16];	/* general purpose registers */
>  };
>  #endif

Don't you have to remove arch.guest_gprs too? (interesting approach btw).

>  
>  int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run)
> @@ -528,7 +528,7 @@ rerun_vcpu:
>  	might_fault();
>  
>  	do {
> -		__vcpu_run(vcpu);
> +		__vcpu_run(vcpu, kvm_run);

kvm_run == vcpu->run, no need for the extra param.

-- 
error compiling committee.c: too many arguments to function