From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [patch 3/3] kvm-s390: provide general purpose registers via kvm_run
Date: Thu, 22 Dec 2011 14:34:35 +0200
Message-ID: <4EF323DB.5000203@redhat.com>
References: <20111222115646.248800653@de.ibm.com> <20111222120054.367076904@de.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tossati <mtosatti@redhat.com>,
	Carsten Otte <cotte@de.ibm.com>,
	Alexander Graf <agraf@suse.de>,
	Jens Freimann <jfrei@linux.vnet.ibm.com>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	KVM <kvm@vger.kernel.org>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:36836 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752636Ab1LVMeq (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 22 Dec 2011 07:34:46 -0500
In-Reply-To: <20111222120054.367076904@de.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 12/22/2011 01:56 PM, Christian Borntraeger wrote:
> From: Christian Borntraeger <borntraeger@de.ibm.com>
>
> The general purpose registers are often necessary to handle SIE exits.
> Avoid additional ioctls by providing the guest registers in the r/w 
> section of the kvm_run structure.
>

This is only needed for S390_UCONTROL?

>  
>  struct sync_rw_regs {
> +	__u64 gprs[16];	/* general purpose registers */
>  };
>  #endif

Don't you have to remove arch.guest_gprs too? (interesting approach btw).

>  
>  int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run)
> @@ -528,7 +528,7 @@ rerun_vcpu:
>  	might_fault();
>  
>  	do {
> -		__vcpu_run(vcpu);
> +		__vcpu_run(vcpu, kvm_run);

kvm_run == vcpu->run, no need for the extra param.

-- 
error compiling committee.c: too many arguments to function