From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 14/23] vhost: convert to MemoryListener API Date: Thu, 22 Dec 2011 14:50:27 +0200 Message-ID: <4EF32793.30108@redhat.com> References: <1324304024-11220-1-git-send-email-avi@redhat.com> <1324304024-11220-15-git-send-email-avi@redhat.com> <20111222125016.GB25538@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Stefano Stabellini , qemu-devel@nongnu.org, xen-devel@lists.xensource.com, kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:63700 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755179Ab1LVMue (ORCPT ); Thu, 22 Dec 2011 07:50:34 -0500 In-Reply-To: <20111222125016.GB25538@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/22/2011 02:50 PM, Michael S. Tsirkin wrote: > On Mon, Dec 19, 2011 at 04:13:35PM +0200, Avi Kivity wrote: > > +static void vhost_log_start(MemoryListener *listener, > > + MemoryRegionSection *section) > > +{ > > + /* FIXME: implement */ > > +} > > + > > +static void vhost_log_stop(MemoryListener *listener, > > + MemoryRegionSection *section) > > +{ > > + /* FIXME: implement */ > > +} > > + > > What exactly do we need to fix here? Tell vhost to start tracking those regions? I guess you don't often read packets into the framebuffer, or we'd have a lot of bug reports. -- error compiling committee.c: too many arguments to function